This repository was archived by the owner on Dec 12, 2022. It is now read-only.
Accidentally modify the whole script accidentally #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubports-qa had a few papercuts. Namely: 1. It wouldn't remount the system when installing or updating 2. It was easy for a developer to forget to mount or unmount (which caused point 1) 3. Failure exits return 0 4. It used the old style of formatting strings which is generally regarded as bad practice 5. Remounting read-only will fail if anything wakes up and grabs a file on the rootfs. Handle that and return an error. 6. It didn't lint. a. Some of the function names clobbered built-in keywords. This fixes that.
NeoTheThird
approved these changes
Sep 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It all started as trying to fix ubports-qa not remounting the root filesystem...
This PR makes the script more """Pythonic""" and self-defensive. It also lints the thing and formats it with Black. This all causes a big diff now but should avoid big diffs in the future.
The specific issues fixed are:
a. Some names clobbered built-in keywords.