New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Morph.Web in the online accounts login #6

Merged
merged 3 commits into from Dec 14, 2018

Conversation

Projects
2 participants
@mardy
Copy link
Member

mardy commented Dec 11, 2018

Working on ubports/ubuntu-touch#983

Seems to work well for Google, not so well for Evernote (the account can still be created, though).

mardy added some commits Dec 11, 2018

plugin: use Morp.Web instead of Ubuntu.Web
The Google plugin could be created without issues; with Evernote, the
<select> HTML controls in the WebView (when choosing for how long we
want to authorize the account) don't make the popup appear, and the UI
got completely frozen at the end of the account creation (which was
anyway successful).

@mardy mardy requested review from mariogrip and UniversalSuperBox Dec 11, 2018

debian/rules: skip tests on arm64
They currently fail in Jenkins
@mariogrip
Copy link
Member

mariogrip left a comment

Looks good 👍

Failing to build is due to arm64 test failed, you may want to disable arm64 on testing?

@mardy mardy merged commit 93e1bc4 into xenial Dec 14, 2018

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@mardy mardy deleted the morph branch Dec 14, 2018

@mariogrip mariogrip added this to Done in OTA-7 Dec 29, 2018

@UniversalSuperBox UniversalSuperBox changed the title Morph Switch to Morph.Web in the online accounts login Dec 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment