Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Called number not seen in call log only contact name #1035

Open
mgresko8 opened this Issue Jan 22, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@mgresko8
Copy link

mgresko8 commented Jan 22, 2019

Description of the feature

When browsing through call log I am not able to see the number, only the contact name. It is very annoying when having more then one number added to the contact. If I called the same contact more time to different numbers, I am not able to select to repeat the call by number of the same contact from the call log.

I am pretty sure the feature was here added by Canonical on my request and somebody removed it.

  • Device: BQ Aquaris E4.5
  • Channel: stable
  • Build: OTA-6

Steps to reproduce

Call (or receive call) to the same contact, but on different numbers. You are not able to see the numbers in the call log.

Expected behavior

Being able to see contact name along with the called number in call log.

Actual behavior

You are only able to see the contact name in the call log.

@mgresko8 mgresko8 changed the title Called number not seen in call log only conect name Called number not seen in call log only contact name Jan 22, 2019

@Gabriele69

This comment has been minimized.

Copy link

Gabriele69 commented Mar 8, 2019

The call information is actually present. It's necessary to scroll to the left the contact that interests you in the call log (incoming or outgoing) and click on the "info" symbol. It is certainly not practical, but it is the way to get the most complete information, since the register groups the incoming and outgoing calls to / from the same user.

@mgresko8

This comment has been minimized.

Copy link
Author

mgresko8 commented Mar 8, 2019

@brickeddroid

This comment has been minimized.

Copy link

brickeddroid commented Mar 22, 2019

Hi guys, i am a total newbie to the github thing, so correct me if I am totally wrong here.
But i have three suggestions to may enhance this issue.
I don't know, if I had to make three different pull requests but I thought it would be better to discuss them first before i make a pull request?!

All suggestions are for the dialer-app/src/qml/HistoryPage/HistoryDetailsPage.qml

  1. pass an additional boolean parameter prioName to the getFormattedPhoneLabel function

then in line 46:
} else if (prioName && contactWatcher.alias != "") {

line 56:
title: getFormattedPhoneLabel(phoneNumber, true)

and line 144:
text: getFormattedPhoneLabel(phoneNumber, false)

  1. maybe a cleaner way would be to "copy" the getFormattedPhoneLabel function and invert the range of the checks

  2. or additional to suggestion 1 or 2 add a completely new label, maybe like it was in former versions

@Gabriele69

This comment has been minimized.

Copy link

Gabriele69 commented Mar 23, 2019

Nope, it was there in the past. But it was removed. When I scrll to left and click the info symbol I see only the name and not the number nowadays. Why it was removed?

Sorry, it's true. I didn't realize that the information did not include the number of the caller.
Having the number could be useful if the caller has more than one phone number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.