New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo on the other side of the line during calls #861

Closed
Spraltik opened this Issue Sep 5, 2018 · 33 comments

Comments

Projects
9 participants
@Spraltik
Copy link

Spraltik commented Sep 5, 2018

  • Device: One Plus One - Bacon
  • Channel: Development
  • Build: 16.04 - Version 471

Steps to reproduce

Calling or receiving a call from another person using the phone app.

Expected behavior

No echo, and normal volume.

Actual behavior

There is a echo for the person on the other end of the line, they hear themselves back with a slight delay. The echo is so annoying that every person I have called mentions it. Also the volume on my phone is at maximum and is still quite low and not affected by the volume buttons (this was not the case on Android).

I have not included logs but will do so if it would help.

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Sep 11, 2018

I cannot reproduce this on my OPO on daily use... Volume control sucks yes, but should be rather too loud than too low. But no echo...

@Spraltik

This comment has been minimized.

Copy link

Spraltik commented Sep 11, 2018

Thanks for your response FLohack74. Just to be sure we are on the same page: the echo is heard by the person on the other end of the phone call, not by you with the OPO right? I can find very few people who are experiencing the same issue as me it seems.

@delijati

This comment has been minimized.

Copy link

delijati commented Sep 19, 2018

I have the same echo effect. But i never used the phone with android. So it could be also the hardware.

@thebosbird

This comment has been minimized.

Copy link

thebosbird commented Sep 20, 2018

@delijati I don't have this on my OPO running 15.04

@Spraltik

This comment has been minimized.

Copy link

Spraltik commented Sep 21, 2018

I found an old thread on the one plus one forums of someone experiencing the same issue on multiple roms: https://forums.oneplus.com/threads/phone-echo-issue.555264/. He also had no issue on Lineage OS up to a certain version. I suspect the same as him that it has something to do with the noise cancellation software not working properly.

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Sep 21, 2018

Can you verify if your OPO shows up as bacon or A0001 in getprop ro.product.device ?

@delijati

This comment has been minimized.

Copy link

delijati commented Sep 21, 2018

  • getprop ro.product.device: bacon
  • os: 16.04.05 LTS 20180921
@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Sep 21, 2018

Ok this is interesting, I got the later model A0001 :) - maybe its hw-specific and we would need some special bits for the other HW variant, could be...

@Spraltik

This comment has been minimized.

Copy link

Spraltik commented Sep 22, 2018

same here:

  • getprop ro.product.device: bacon
  • os: Ubuntu 16.04 (2018-W35)
@Spraltik

This comment has been minimized.

Copy link

Spraltik commented Oct 4, 2018

I did some more searching and found this thread on the oneplusone forums: https://forums.oneplus.com/threads/problem-speakerphone-echo.376902/page-3 they seem to have similar issues. It changes depending on what ROM they use so I still think it's fixable through software. I think post 47 might be on to something. I believe the issue is due to the noice cancelling microphone not working and therefore the microphone is picking up the sounds from the speaker. He writes the following suggestion:

On cyanogenmod you need to edit /system/build.prop and add the following lines if they are not already there

persist.audio.fluence.mode=fluence

persist.audio.vr.enable=false

persist.audio.handset.mic=analog

persist.audio.voice.clarity=none

persist.audio.fluence.voicecall=true

persist.audio.fluence.voicerec=false

persist.audio.fluence.speaker=true

You can edit the file using root explorer. Please try this and let me know if it's working. It's supposed to turn on noise suppression

I can't seem to get write permissions from the terminal with: sudo nano build.prop it gives me the following error: "Unable to create directory /root/.nano: Read-only file system. I have been able to read the file do and the only line I could find back in it at the bottom was "persist.audio.fluence.voicecall=true". So perhaps adding the other lines might fix the issue? Can anyone explain to me how I can get root permissions to write into the build.prop file?

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Oct 4, 2018

This is not so easy, near impossible, but we can inject this in our build services and then try to build it. Le me see if I can get this done.

Flohack74 added a commit to ubports/android_device_oneplus_bacon-1 that referenced this issue Oct 4, 2018

@Spraltik

This comment has been minimized.

Copy link

Spraltik commented Oct 6, 2018

Thanks a bunch for trying to inject this Flohack74! Should I switch my update channel to "development" (I'm currently on stable again) to see if it worked by the time it has been injected?

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Oct 6, 2018

The PR is still open, so you need to wait until ubports/android_device_oneplus_bacon-1#11 is marked as Merged.

@Flohack74 Flohack74 added this to the 16.04 OTA-5 milestone Oct 7, 2018

@Flohack74 Flohack74 added this to Quality Assurance in Ubuntu Touch Oct 7, 2018

@Flohack74 Flohack74 self-assigned this Oct 7, 2018

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Oct 8, 2018

Please test whether this echo occurs today

@Sconioo

This comment has been minimized.

Copy link

Sconioo commented Oct 22, 2018

I have a similar problem with my OPO,

When someone calls me, he can hear himself ( echo )

photo_2018-10-22_21-49-59

This problem goes away immediately when using a wired headset.

The bug is in both 15.04 and 16.04

@wayneoutthere

This comment has been minimized.

Copy link

wayneoutthere commented Oct 22, 2018

If it's helpful, this problem used to exist in the N5 and I think also the N4. The description seems exactly the same.

@Spraltik

This comment has been minimized.

Copy link

Spraltik commented Oct 24, 2018

Thanks Sconioo for that drawing!
The problem is still there and recently media started being played through the "earphone" instead of the speakers at the bottom of the phone. I'm still convinced "mic 2" acting as a normal microphone when it should be a noise cancelling one. I think it is picking up the sound of the earphone because it is so close to it.

  • Actually the media being played through the earphone was an issue of RC 18 and has been fixed with RC 19. Still no hope for the echo do. Why did UniversalSuperBox close the topic anyway?
@delijati

This comment has been minimized.

Copy link

delijati commented Oct 25, 2018

Same here the problem still exists.

Ubuntu Touch automation moved this from Quality Assurance to In Development Oct 25, 2018

@mariogrip mariogrip removed this from the 16.04 OTA-5 milestone Oct 29, 2018

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Nov 17, 2018

I added missing acdbdata and mixer_paths.xml to the image, can you please re-test with todays nightly devel build?

@delijati

This comment has been minimized.

Copy link

delijati commented Nov 17, 2018

Awesome so far this works for me. No "Echo" on the other side. But now if i activate hand free mic, the other side is not hearing me.

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Nov 18, 2018

Ok will test further... :)

@Flohack74 Flohack74 added this to the 16.04 OTA-6 milestone Nov 18, 2018

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Nov 19, 2018

Hmm I try currently to partially revert this stuff ubports/android_device_oneplus_bacon-1#11 and then also to increase volume of the mics. Lets see...

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Nov 19, 2018

Can you try to install today´s devel? Should be better now ;)

@Spraltik

This comment has been minimized.

Copy link

Spraltik commented Nov 20, 2018

Flohack74, I want to sincerely thank you for fixing this issue! I have made calls the last couple of days and everybody said the echo issue was gone. Also the volume adjustment during calls now works and the volume is much better. Finally the phone is doing what it was meant for well :). I'll make a small donation today for your help.

@delijati

This comment has been minimized.

Copy link

delijati commented Nov 20, 2018

@Flohack74 thanks so much for this :) Now also the "hand free" mic works but with the an echo. But that is fine for me. The biggest issue was the "normal" echo and this is resolved.

@Sconioo

This comment has been minimized.

Copy link

Sconioo commented Nov 20, 2018

@Flohack74 Thank you sincerely for having solved the problem, now the echo to disappear, which (at the same time) makes the use of Linphone more pleasant
Nice work :)

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Nov 20, 2018

@delijati What is "an echo"?

@Flohack74 Flohack74 closed this Nov 20, 2018

Ubuntu Touch automation moved this from In Development to Quality Assurance Nov 20, 2018

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Nov 20, 2018

Thanks guys, was a pain for me as well. Next thing I try to take a look at is missing camera flash xD

@wayneoutthere

This comment has been minimized.

Copy link

wayneoutthere commented Nov 20, 2018

nice work man

@delijati

This comment has been minimized.

Copy link

delijati commented Nov 20, 2018

@delijati What is "an echo"?

It's the same "echo" for the caller as it was with normal mic just in the "hand free" mode.

@UniversalSuperBox UniversalSuperBox added this to To do in OTA-6 QA Tracker via automation Nov 23, 2018

@tomoqv

This comment has been minimized.

Copy link

tomoqv commented Dec 3, 2018

Is the code for this bugfix in any way affecting the Pro5 also? I have noticed a severe degradation of voice call quality recently, could be since updating to the latest RC. Sound is very choppy at both ends, almost like with a really bad GSM connection even though the connection looks fine and used to work without any choppiness in my house.

@tomoqv

This comment has been minimized.

Copy link

tomoqv commented Dec 3, 2018

I could add that I today did a fresh install including wipe of my Pro 5. Have only tested one call so far, but problem seems to persist.

@Flohack74

This comment has been minimized.

Copy link
Member

Flohack74 commented Dec 5, 2018

No, this was only applied to the hardware adaption repo of OPO.

@UniversalSuperBox UniversalSuperBox moved this from To do to Accepted in OTA-6 QA Tracker Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment