New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when determining the height of the keyboard rectangle, take Screen.devicePixelRatio into account #25

Open
wants to merge 1 commit into
base: xenial
from

Conversation

Projects
None yet
2 participants
@balcy
Copy link

balcy commented Nov 3, 2018

without that the popups are scrolled up too much, if the on screen keyboard is shown

see issue ubports/morph-browser#52 of morph-browser

fixes ubports/morph-browser#52

when determining the height of the keyboard rectangle, take Screen.de…
…vicePixelRatio into account

without that the popups are scrolled up too much, if the on screen keyboard is shown
@balcy

This comment has been minimized.

Copy link

balcy commented Nov 7, 2018

@mariogrip do you know why it could not be built ? The error messages in the Jenkins seem not connected to the code change...

@UniversalSuperBox UniversalSuperBox self-assigned this Nov 10, 2018

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Nov 11, 2018

It looks like the failure is due to failing tests, which previously were ignored due to tests not being enabled on CI. We should fix those tests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment