Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the builds pass again on xenial #31

Merged
merged 56 commits into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@dobey
Copy link
Member

dobey commented Jan 31, 2019

This merges back some changes from bionic, and re-enables a lot of tests, while fixing some others. There are still several problematic tests remaining, which have been skipped. The armhf build is also still problematic, very likely due to some configuration on the build server, so we need so skip it here, along with arm64 which is still problematic on xenial.

This fixes multiple open bugs, including #28 #26 #12 and #9.

mariogrip and others added some commits Feb 12, 2018

Workaround for silly bug
Will crap out with "Project ERROR: You cannot build examples inside the
Qt source tree, except as part of a proper Qt build." but running qmake
first without config seems to work
Disable i18n type since QT disallows lowercase types
This does not effect i18n context prop, so i18n will work as normaly

qt/qtdeclarative@1e350a8
Merge pull request #8 from ubports/bionic_-_i18nfix
Disable i18n type since QT disallows lowercase types
If Qt HiDpi scaling is active, use that insted of GRID_UNIT_PX
This is the first move to depricate GRID_UNIT_PX all togheter
Add back m_devicePixelRatio to make sure we dont make regression
devicePixelRatio should always be 1 if qts hidpi is disabled afaik, but lets add it back to be sure
Refactor apicheck to use QQmltype scalar
We were seeing issues with using apicheck on Qt 5.9.5. Really strange
memory issues leading to segfaults. This commit refactors apicheck
to use the scalar QQmlType everywhere and fix any compile issues
that cropped up.
Update README and control to specify Qt 5.9
My changes to apicheck in
d85ab39
make us incompatible with anything less than Qt 5.9

dobey added some commits Jan 21, 2019

Remove contenthub test and re-enable others.
As contenthub is a separate repository, this test is no longer valid here.
With some of the other fixes, these other tests can be re-enabled now.
Replace waitForEvents with processEvents.
This should resolve #12 when merged to the bionic branch.
@UniversalSuperBox
Copy link
Member

UniversalSuperBox left a comment

The commit path looks good and the resulting build manually tests fine on my devices. Merge when ready.

@UniversalSuperBox UniversalSuperBox merged commit f9c9b9e into xenial Feb 8, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@UniversalSuperBox UniversalSuperBox deleted the xenial_-_fix-failing-uitk-tests branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.