Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove 'Ubuntu Store' #2
Conversation
sverzegnassi
added some commits
Dec 13, 2017
|
Do not merge yet |
|
I enabled branch protection. |
sverzegnassi
added some commits
Dec 13, 2017
|
It built, good job! If you think it's ready and want review, say the word. |
sverzegnassi
added some commits
Dec 14, 2017
|
@NeoTheThird We're ready! \o/ I realize that it's impossible to review this PR. I apologize, but it was inevitable. Long story short: the app scope was actually another interface to the Ubuntu Store. There's for sure some dead code into the source code; however, we can safely say that there is no code that use a network connection. I tested it for a while, and everything seems to work well. In order to get the QA working faster, here's a small list of things to check:
|
|
Great work, thank you!
Yeah, never mind. I'm not reading 5000 lines :P Let's get this merged, it seems to me like it should work. And if it doesn't, well, at least we'll be able to see it faster with more eyes on devel. |
sverzegnassi commentedDec 13, 2017
No description provided.