Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofocus first text field in every page of Welcome Wizard #80

Merged
merged 2 commits into from Feb 24, 2019

Conversation

Projects
None yet
3 participants
@nikalon
Copy link
Contributor

nikalon commented Oct 21, 2018

It's a hacky approach to autofocus elements but I couldn't get it to work by just setting focus: true in every text field.

property string title: ""

signal backClicked()

visible: false
anchors.fill: parent

onVisibleChanged: {
if (focusItem) {

This comment has been minimized.

@mardy

mardy Oct 24, 2018

Member

better change the condition to if (visible && focusItem), as this might be invoked also when the page gets hidden.

@UniversalSuperBox
Copy link
Member

UniversalSuperBox left a comment

This tests fine for me. @mardy, another review?

@UniversalSuperBox UniversalSuperBox requested a review from mardy Feb 9, 2019

Tests fine for me, review timed out :P

@UniversalSuperBox UniversalSuperBox merged commit bd11a94 into ubports:xenial Feb 24, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Feb 24, 2019

@nikalon, are you okay if your real name (as listed on GitHub) is posted in the OTA-8 Call for Testing and Release blog post in the Changelog section? Otherwise, we'll credit nikalon.

Either way, this PR will be linked in both posts.

@nikalon

This comment has been minimized.

Copy link
Contributor Author

nikalon commented Feb 25, 2019

@nikalon, are you okay if your real name (as listed on GitHub) is posted in the OTA-8 Call for Testing and Release blog post in the Changelog section? Otherwise, we'll credit nikalon.

Either way, this PR will be linked in both posts.

You can use my real name if you want, thanks for asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.