Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update com.canonical.Unity8.gschema.xml #83

Merged
merged 1 commit into from Mar 18, 2019

Conversation

@kugiigi
Copy link
Contributor

commented Nov 3, 2018

Changed "edge-barrier-sensitivity" from "y" to "u"
UT Tweak Tool has an error setting this schema key because it is set to "y" (guchar).
Other keys that involves a numerical range in Unity8 are set to "u" so maybe this is the correct one for "edge-barrier-sensitivity" as well.

Update com.canonical.Unity8.gschema.xml
Changed "edge-barrier-sensitivity" from "y" to "u"
@UniversalSuperBox

This comment has been minimized.

Copy link
Member

commented Feb 10, 2019

Can this change be applied without any migration? Does unity8 continue to work correctly?

@kugiigi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

Can this change be applied without any migration? Does unity8 continue to work correctly?

I'm not exactly sure but when I changed it on my device, it was working fine.

@UniversalSuperBox
Copy link
Member

left a comment

Seems like this is a compatible type change, so let's do it!

@UniversalSuperBox UniversalSuperBox merged commit 012d0ef into ubports:xenial Mar 18, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@UniversalSuperBox

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

For QA, the main thing is to ensure that edge swipe behavior is as expected. If you had a custom value set before, check if it's still set properly.

@UniversalSuperBox UniversalSuperBox added this to In progress in OTA-9 via automation Mar 18, 2019

@UniversalSuperBox UniversalSuperBox moved this from In progress to QA in OTA-9 Mar 18, 2019

@jezek

This comment has been minimized.

Copy link

commented May 5, 2019

FP2 (2019-W18)
Edge swipe behavior is as expected, no change.

@ziggutas

This comment has been minimized.

Copy link

commented May 7, 2019

BQ E4.5 rc (2019-W18)
Edge swipe same as before

@ziggutas

This comment has been minimized.

Copy link

commented May 7, 2019

Nexus 7 (flo) rc (2019-W18)
Same as before

@UniversalSuperBox UniversalSuperBox moved this from QA to Done in OTA-9 May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.