Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup u8 tests and remove oxide to make arm64 happy #91

Merged
merged 5 commits into from Feb 8, 2019

Conversation

Projects
3 participants
@mariogrip
Copy link
Member

mariogrip commented Jan 7, 2019

No description provided.

@mariogrip mariogrip requested a review from UniversalSuperBox Jan 7, 2019

@mariogrip mariogrip added this to In progress in OTA-8 via automation Jan 7, 2019

@mariogrip

This comment has been minimized.

Copy link
Member Author

mariogrip commented Jan 7, 2019

on hold
lets wait until we know oxide wont get removed (from edge's rootfs), if so we want to add oxide to armhf meta package.

Show resolved Hide resolved plugins/Wizard/System.cpp Outdated
@UniversalSuperBox
Copy link
Member

UniversalSuperBox left a comment

I've ensured that this won't remove oxide from the image and updated the indentation. Waiting for @dobey to re-check

@dobey

dobey approved these changes Feb 8, 2019

@dobey dobey merged commit ccea24e into xenial Feb 8, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

OTA-8 automation moved this from In progress to QA Feb 8, 2019

@dobey dobey deleted the xenial_-_edge branch Feb 8, 2019

@UniversalSuperBox UniversalSuperBox moved this from QA to Done in OTA-8 Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.