Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for double strongs references #42

Merged
merged 1 commit into from Feb 6, 2020
Merged

Conversation

@jonBitgood
Copy link
Contributor

jonBitgood commented Feb 3, 2020

The char documentation for w states that the strongs references allow multiple numbers per attribute.

strong="H01234,G05485"

However the regex doesn't match this use case.

Changing Line 610 of the rnc from

attribute strong { xsd:string { pattern = "[HG]\d{4,5}(:[a-z])?"} }?

to:

attribute strong { xsd:string { pattern = "([HG]\d{4,5}(:[a-z])?,?)+"} }?

Fixes this

@jonBitgood jonBitgood requested a review from klassenjm Feb 4, 2020
@klassenjm klassenjm added this to the 3.0.1 milestone Feb 6, 2020
@klassenjm klassenjm changed the base branch from master to usx3.0.1 Feb 6, 2020
Copy link
Contributor

klassenjm left a comment

Thanks for this fix @jonBitgood

@klassenjm klassenjm merged commit bb4d785 into ubsicap:usx3.0.1 Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.