Add support for mesa libraries. #204
Conversation
kyrofa
force-pushed
the
ld_library_path_opengl
branch
from
d2bc05b
to
b6296cb
Compare
|
|
||
| tempdirObj = tempfile.TemporaryDirectory() | ||
| self.addCleanup(tempdirObj.cleanup) | ||
| os.chdir(tempdirObj.name) |
There was a problem hiding this comment.
We already have this on the base setup, when this test runs the cwd is already a tempdir that will be deleted. Tha path to that dir is in self.path.
https://github.com/ubuntu-core/snapcraft/blob/master/snapcraft/tests/__init__.py#L33
There was a problem hiding this comment.
Ah good find! I was copying what was already there-- I've fixed the rest of the tests as well.
kyrofa
force-pushed
the
ld_library_path_opengl
branch
from
b6296cb
to
c5e2f5a
Compare
|
lgtm. Maybe, I would move the library handling to a new module. snapcraft/libraries? Thanks for the example! |
kyrofa
force-pushed
the
ld_library_path_opengl
branch
from
c5e2f5a
to
e967ae3
Compare
|
@ElOpio alright I moved it into |
|
I re triggered the examples test run |
| @@ -0,0 +1,50 @@ | |||
| # -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*- | |||
| # | |||
| # Copyright (C) 2015 Canonical Ltd | |||
|
What wishlist bug is this closing? 😉 |
Currently Snapcraft adds only a few standard paths to LD_LIBRARY_PATH. This commit expands that to include paths used by mesa packages. Also add an opencv example to exercise this. Signed-off-by: Kyle Fazzari <kyle@canonical.com> LP: #1531620
kyrofa
force-pushed
the
ld_library_path_opengl
branch
from
e967ae3
to
da00836
Compare
|
@sergiusens heh. Fixed 😃 . |
|
👍 |
Add support for mesa libraries.
Add support for mesa libraries.
Currently Snapcraft adds only a few standard paths to LD_LIBRARY_PATH. This PR expands that to include paths used by mesa packages.
This will need to be backported to 1.x once approved.
Resolves LP: #1531620