Added the snapcraft PR job. #40

Merged
merged 4 commits into from Jan 13, 2016

Conversation

Projects
None yet
2 participants
Owner

elopio commented Jan 12, 2016

No description provided.

+ <hudson.tasks.Shell>
+ <command>#!/bin/bash
+sudo apt-get install -y build-essential bzr dpkg-dev git mercurial pyflakes python3.4 python3-apt python3-docopt python3-coverage python3-fixtures python3-jsonschema python3-mccabe python3-pep8 python3-pip python3-requests python3-testscenarios python3-testtools python3-yaml python3-lxml squashfs-tools
+
@elopio

elopio Jan 13, 2016

Owner

@fgimenez I'm not sure if this will be the way to install deps in the slaves.

@fgimenez

fgimenez Jan 13, 2016

Contributor

IMO it would be better to do that in the Dockerfile, we don't need to repeat these steps on each job execution, even if only the first one would do the actual installation. When the slaves will be ephemeral it will make even more sense, they will need to spawn with all the required dependencies installed, if not, because they will die when the job finishes, the installation will happen on each execution.

+ release="rolling"
+fi
+
+snappy-cloud-client create -release $release -channel edge > instance.info
@elopio

elopio Jan 13, 2016

Owner

@fgimenez it seems that this command is not installed in the current jenkins. Reprovisioning it would get the newer snappy-jenkins-job?

@fgimenez

fgimenez Jan 13, 2016

Contributor

mm you mean snappy-cloud-image and snappy-tests-job, right? :) Reprovisioning will get the latest available versions of both executables, now that we are using slaves they will get installed there instead of the master.

However I think that you don't need to create the image from the job, there are specific jobs that are polling system-image (mental note, we should modify this to target the store somehow), generate the image and trigger a downstream job to test it. Is that enough or am I missing something?

+
+trap "snappy-cloud-client kill $id" EXIT
+
+./runtests.sh examples --subunit --ip $ip
@fgimenez

fgimenez Jan 13, 2016

Contributor

Ok, now I understand, snappy-cloud-client comes with the latest snappy-tests-job, if you try a fresh deploy with the current tip of master it should be available there

Contributor

fgimenez commented Jan 13, 2016

👍 only needing to move the package installation to the slave's Dockerfile

Owner

elopio commented Jan 13, 2016

Thanks for the review @fgimenez. I moved the deps to the Dockerfile. Please take another look.

Contributor

fgimenez commented Jan 13, 2016

ok thanks!

fgimenez added a commit that referenced this pull request Jan 13, 2016

Merge pull request #40 from elopio/snapcraft
Added the snapcraft PR job.

@fgimenez fgimenez merged commit 407a4b4 into ubuntu-core:master Jan 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment