jobs: use the github plugins instead of snappy-tests-job to get the branc #72

Merged
merged 2 commits into from Feb 9, 2016

Conversation

Projects
None yet
2 participants
Owner

elopio commented Feb 9, 2016

No description provided.

Contributor

fgimenez commented Feb 9, 2016

The shell script for executing the jobs is great, it would be awesome if we could reuse it somehow. Maybe adding a execute-ci.sh file in the source code of the project and letting the jobs just call it, or use this plugin [1]

Why are you removing the snappy-cloud-test job? It's the downstream job triggered after a new image has been built, the first one that exercises it. Actually the daily ones could be replaced by this one.

[1] https://wiki.jenkins-ci.org/display/JENKINS/Managed+Script+Plugin

Owner

elopio commented Feb 9, 2016

My fear about reusing it is that it will turn in snappy-tests-job, with tons of flags that we need to constantly extend. I would prefer to reduce it to a handful of scripts. First, we'll remove three statements with ubuntu-core/snappy/465. Then, we can modify integration-tests/main.go to generate the xml. I was thinking about how to reduce the testbed creation and delete to one statement, but I have no ideas there. Instead of having jenkins managing this scripts, I would like us to put them in the repo in .jenkins or something like that. I don't have a clear idea about how to specify the multiple scenarios that we are running here, though.

I removed snappy-cloud-test because I can't clone with the plugin master and 15.04 on the same job. As we already have the dailies that do the same, I just added the channel parameter to them.

Contributor

fgimenez commented Feb 9, 2016

Ok, we can begin with this and refactor later. Sorry, didn't notice the changes in the jobs triggered by the create jobs, LGTM

elopio added a commit that referenced this pull request Feb 9, 2016

Merge pull request #72 from elopio/no-snappy-tests-job
jobs: use the github plugins instead of snappy-tests-job to get the branc

@elopio elopio merged commit e6545f0 into ubuntu-core:master Feb 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@elopio elopio deleted the elopio:no-snappy-tests-job branch Feb 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment