Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use YaruSliderSecondary widget #251

Merged
merged 5 commits into from
Jan 14, 2022
Merged

Don't use YaruSliderSecondary widget #251

merged 5 commits into from
Jan 14, 2022

Conversation

mivoligo
Copy link
Collaborator

Removed use of the YaruSliderSecondary from A11y page UI.

@Feichtmeier
Copy link
Member

Thanks @mivoligo !
I think the test is failing because pubspec.lock points to the wrong yaru_widgets version where the enabled property was not there yet 🤔 That would mean that I committed the wrong one which would be weird because I needed the most recent versions for my builds to work. Does it work for you locally?

@mivoligo
Copy link
Collaborator Author

It worked locally. I had to run pub upgrade though.

@Feichtmeier
Copy link
Member

Could you try to commit pubspec.lock then?

@mivoligo
Copy link
Collaborator Author

hmmm... I see the resolved-ref is the same in my lock file: resolved-ref: f93fbba83b25265c9941ef59d5eb6bbeafc0eaa0 and the file is actually not changed compared to master branch.

@mivoligo
Copy link
Collaborator Author

I've recreated the lock file. Not sure why it worked for me.

@Feichtmeier Feichtmeier merged commit b3d3a7e into master Jan 14, 2022
@Feichtmeier Feichtmeier deleted the a11y_ui_fixes branch February 3, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants