Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated yaru_widgets.dart #257

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Use updated yaru_widgets.dart #257

merged 3 commits into from
Jan 21, 2022

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Jan 20, 2022

yaru_widgets is now a lot more flexible with pages, sections and rows.
This PR uses the new yaru widgets version from git and also sneakily fixes an error in the info page with a missing asset in pubspec.yaml :)
No visual changes (I hope)

@Jupi007 and/or @mivoligo can you double check?
You might need to pub upgrade and then get to use the new version of yaru widgets also locally

@mivoligo
Copy link
Collaborator

I'll try to check it tomorrow.

@mivoligo
Copy link
Collaborator

mivoligo commented Jan 21, 2022

After looking everything seems to work fine except for sliders inside dialogs :)
Looks like you've removed the default width in YaruRow (ubuntu/yaru.dart#54) which results in the layout not being able to calculate constraints, when slider is used in a dialog.
I've added quick fix for that.

@Feichtmeier
Copy link
Member Author

Feichtmeier commented Jan 21, 2022

oh! Thanks 🥂
could you use this kDefaultWidth constant instead?

@mivoligo
Copy link
Collaborator

sure, didn't noticed it before 😄

@Feichtmeier
Copy link
Member Author

it's all new and shiny! :D
In the near future we should change the YaruSimpleDialog to force his width on his children.

@Feichtmeier Feichtmeier merged commit e3a5851 into master Jan 21, 2022
@Feichtmeier Feichtmeier deleted the use_updated_yaru_widgets branch February 3, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants