Try fixing flaky "pick up config changes" tests #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is still failing randomly in the archive or in autopkgtests on armhf and arm64. Change thus the approach to define phases: - First phase is initial configuration set - Second optional phase is a configuration change for some tests - Third phase is the "done" one. This way, we control the amount of callbacks we are interested in and picking, discaring the unwanted multiple inotify event for the same write on disk. It seems to make the flaky failure (which only impacts tests, as in a real system, we are interested even in no-op changes) go away on arm64 after multiple attempts.
Codecov Report
@@ Coverage Diff @@
## main #297 +/- ##
==========================================
+ Coverage 84.68% 84.73% +0.05%
==========================================
Files 56 56
Lines 3905 3905
==========================================
+ Hits 3307 3309 +2
+ Misses 375 374 -1
+ Partials 223 222 -1
Continue to review full report at Codecov.
|
jibel
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is still failing randomly in the archive or in autopkgtests on
armhf and arm64.
Change thus the approach to define phases:
This way, we control the amount of callbacks we are interested in and
picking, discaring the unwanted multiple inotify event for the same
write on disk.
It seems to make the flaky failure (which only impacts tests, as in a
real system, we are interested even in no-op changes) go away on arm64
after multiple attempts.