Initial addition of ubuntu-app-platform shared snap use for Qt and other Ubuntu's libraries.

[tjyrinki]

No description provided.

[tjyrinki]

For comments or to be merged after fixes. Not sure how to test this locally, but the working example of using ubuntu-app-runtime snap is at timostestapp3. Integrating the launcher specifities to here should be straight-forward, but I'm not sure about if the content plug can be auto-enabled via cloud part or if the five lines to define it and its (what should be fixed) mount point still need to be copy-pasted by the app developer.

[didrocks]

Excellent work Timo! I really like this patch and I would have come up with a very similar solution.
I have a few comments though to enhance it, but the general idea is perfect!

[didrocks]

Here or above (under that variable condition), I would add a test like:
ls -d $SNAP/ubuntu-app-runtime >/dev/null 2>&1 and it that fails, prints:

You need to connect the ubuntu-app-runtime package with your application to reuse shared assets, please run:
snap install ubuntu-app-runtime
snap connect ubuntu-app-runtime:platform $SNAP_NAME:platform

For instance :)

[didrocks]

I would name that plug "platform" (on both sides) as it provides a platform and we want multiple apps to support it. That way, we can standard the plug and slot name for all platform snap. Making sense?

[tjyrinki]

Yes it makes sense and also shorter for connecting and use.

[didrocks]

I would add here the example you provided:

plugs:
  ubuntu-app-runtime:
      content: ubuntu-app-runtime
      interface: content
      target: ubuntu-app-runtime

Indeed, we can't in cloud parts (maybe open a bug for this?) share standard plugs definition. So we need to document it.

A note (and that will impact your content interface as well), please please, version your content interface. It's the only way to ensure that we can't get into a breakage after an API or ABI changes. So I would suggest content: ubuntu-app-runtime1 (or whatever version). The content is what you version on both sides.

[didrocks]

oh, as well, please provide default-provider: ubuntu-app-platform (snap name). Once this is implemented, installing the application will install the content interface snap at the same time (it's not implemented though right now)

[tjyrinki]

Done in the second commit. Bug filed at http://pad.lv/1639751

[didrocks]

This stenza isn't necessary. It was for backward compatibility reason with the new desktop- syntax. You can remove it as we never published that new part with the desktop/ syntax.

[tjyrinki]

Ok!

[didrocks]

Same remark than above

[didrocks]

I would add here the example you provided:

plugs:
  ubuntu-app-runtime:
      content: ubuntu-app-runtime
      interface: content
      target: ubuntu-app-runtime

Indeed, we can't in cloud parts (maybe open a bug for this?) share standard plugs definition. So we need to document it.

A note (and that will impact your content interface as well), please please, version your content interface. It's the only way to ensure that we can't get into a breakage after an API or ABI changes. So I would suggest content: ubuntu-app-runtime1 (or whatever version). The content is what you version on both sides.

[didrocks]

oh, as well, please provide default-provider: ubuntu-app-platform (snap name). Once this is implemented, installing the application will install the content interface snap at the same time (it's not implemented though right now)

[tjyrinki]

Done in the second commit. Bug filed at http://pad.lv/1639751

[tjyrinki]

Ok the second commit hopefully addresses all the comments so far. Also updated the testapp example in other repository which still didn't use "platform" name correctly.

[didrocks]

A last nitpick, and once done, good for merging! Excellent work again :)

[didrocks]

It's just a matter of preference, but can you just condense that in one line (just use backticks so that it doesn't depend on bash), as in other part of the launcher, thanks!

[didrocks]

Thanks for addressing all remarks!