Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapcraft.yaml: add dependency on remote indicator parts #26

Merged
merged 1 commit into from
Nov 24, 2016

Conversation

3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented Nov 21, 2016

This adds dependency on indicator- parts
to add support to desktop indicators with snap
support patches.

Parts are currently defined at:

While examples of indicators for various toolkits are

This adds dependency on indicator-<toolkit> parts
to add support to desktop indicators with snap
support patches.

Parts are currently defined at:
 - https://github.com/3v1n0/appindicators-snapcraft-parts

While examples of indicators for various toolkits are
 - https://github.com/3v1n0/indicators-examples-snaps
@didrocks
Copy link
Member

Hey @3v1n0! I would like this to get merged. However, I see that this will make the Qt parts depending on gtk due to this new part. Any chance to remove this dependency? I don't think people having some dependencies on Qt are keen to get gtk embeded for space constraints :)

Also, do you mind thinking of having it embeded in the ubuntu-app-platform, and get the support in the launcher for this case?
Thanks!

@3v1n0
Copy link
Contributor Author

3v1n0 commented Nov 23, 2016

@didrocks wasn't this already the case for qt5 apps?

appmenu-qt5 was included, which depends on libgtk2.0-0. That was already almost the case in order to get unity style and menus integration, though.

However appmenu-qt5 (which gives us both menus and tray icon support) has only a tiny dependency on GtkSettings (to get the icon theme name), which I could easily change by using dlload with it, if you'd prefer.

In any case I guess that anyone using these shared parts could just override the after array in their snapcraft.yaml, removing the dependency on indicator-qtX if they don't need it, isn't it?

Also, do you mind thinking of having it embeded in the ubuntu-app-platform

I think all this stuff should be inside a shared part, so.... Yeah. I was just wondering if this is something that that content interface is only for classic desktop or for both. If we want to cover both, indeed it has to be there too.

and get the support in the launcher for this case?

What you mean with that?

@didrocks
Copy link
Member

Ok, fair enough for gtk*, and as you told, people can overide in the after: keyword as well.
Do you mind setting that up (+ the fact that people needs to use the unity7 interface to use the indicator integration?) in the description and guide on top?

On the ubuntu-app-platform: indeed, it should be in the content interface snap directly, mind coordinating with Mirv so get indicator support there? If anything in needed on the launcher side (like override env variable or such), you can always open another PR!

Merging then, thanks! :)

@didrocks didrocks merged commit ac71e83 into ubuntu:master Nov 24, 2016
didrocks added a commit that referenced this pull request Nov 24, 2016
It seems that snapcraft cloud parts or importer doesn't handle properly parts
depending on parts. The desktop parts disappeared from snapcraft search.
This reverts commit ac71e83, reversing
changes made to 1714422.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants