Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
snapcraft.yaml: add dependency on remote indicator parts #26
Conversation
|
Hey @3v1n0! I would like this to get merged. However, I see that this will make the Qt parts depending on gtk due to this new part. Any chance to remove this dependency? I don't think people having some dependencies on Qt are keen to get gtk embeded for space constraints :) Also, do you mind thinking of having it embeded in the ubuntu-app-platform, and get the support in the launcher for this case? |
|
@didrocks wasn't this already the case for qt5 apps? appmenu-qt5 was included, which depends on However appmenu-qt5 (which gives us both menus and tray icon support) has only a tiny dependency on GtkSettings (to get the icon theme name), which I could easily change by using dlload with it, if you'd prefer. In any case I guess that anyone using these shared parts could just override the
I think all this stuff should be inside a shared part, so.... Yeah. I was just wondering if this is something that that content interface is only for classic desktop or for both. If we want to cover both, indeed it has to be there too.
What you mean with that? |
|
Ok, fair enough for On the ubuntu-app-platform: indeed, it should be in the content interface snap directly, mind coordinating with Mirv so get indicator support there? If anything in needed on the launcher side (like override env variable or such), you can always open another PR! Merging then, thanks! :) |
3v1n0 commentedNov 21, 2016
This adds dependency on indicator- parts
to add support to desktop indicators with snap
support patches.
Parts are currently defined at:
While examples of indicators for various toolkits are