/snapcraft-desktop-helpers

Runtime refactor #34

Merged
merged 10 commits into from Jan 30, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@didrocks
@didrocks
Owner

didrocks commented Jan 17, 2017 •
Edited 1 time

Simplify and use RUNTIME refactoring by adding snap-specific libs to runtime ones.
Do it on both GTK and Qt sides.

Change slightly the logic by allowing generic init/runtime/generic desktop/specific desktop override order.

didrocks added some commits Dec 13, 2016

@didrocks
Separate init from desktop-exports common part 
Ensure we still build it, but separate it so that we can add a RUNTIME
detection check.
3598af3
@didrocks
Add runtime export for GTK 
Based on Sebastien Bacher's work, make runtime export more generic and
detected even before running general detection work. Then,  based on this
RUNTIME value to run all helpers and export all variables.
93809fd
@didrocks
Adapt new runtime strategy to Qt ubuntu-app-platform 
Simplify drastically the code by using the same logic than GNOME runtime.
054ede7
@didrocks
gnome runtime is in the edge channel
113b91a
@didrocks
Add SNAP specific paths when using runtime. 
We ensure we always prepending SNAP specific paths as first list element,
then use runtime ones before system ones.
Initial patch from Sebastien Bacher.
f39f429
@didrocks
Add comment when using localSNAP assets when a runtime is used.
42aed06
@didrocks
Merge branch 'master' into runtime-refactor 
Rebase on check if XDG_SESSION_TYPE is set to x11, otherwise default to Mir
59f212a
@didrocks
Fix missing RUNTIME reference
832ad64
@didrocks
Add specific snap QML2_IMPORT_PATH for imported libraries
57381ee
@didrocks
Change syntax to more explicit "WITH_RUNTIME"
60c15af
@didrocks
Owner

didrocks commented Jan 30, 2017

Gtk side is working, no feedback from Qt one, merging this.

@didrocks didrocks merged commit d2eb3db into master Jan 30, 2017

@didrocks didrocks deleted the runtime-refactor branch Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment