Runtime refactor #34
Merged
Runtime refactor #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure we still build it, but separate it so that we can add a RUNTIME detection check.
Based on Sebastien Bacher's work, make runtime export more generic and detected even before running general detection work. Then, based on this RUNTIME value to run all helpers and export all variables.
Simplify drastically the code by using the same logic than GNOME runtime.
We ensure we always prepending SNAP specific paths as first list element, then use runtime ones before system ones. Initial patch from Sebastien Bacher.
Rebase on check if XDG_SESSION_TYPE is set to x11, otherwise default to Mir
|
Gtk side is working, no feedback from Qt one, merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify and use RUNTIME refactoring by adding snap-specific libs to runtime ones.
Do it on both GTK and Qt sides.
Change slightly the logic by allowing generic init/runtime/generic desktop/specific desktop override order.