snapcraft.yaml: add dependency on remote indicator parts #36

Merged
merged 1 commit into from Feb 15, 2017

Conversation

Projects
None yet
2 participants
Contributor

3v1n0 commented Jan 18, 2017

This adds dependency on indicator- parts
to add support to desktop indicators with snap
support patches.

Parts are currently defined at:

While examples of indicators for various toolkits are

snapcraft.yaml: add dependency on remote indicator parts
This adds dependency on indicator-<toolkit> parts
to add support to desktop indicators with snap
support patches.

Parts are currently defined at:
 - https://github.com/3v1n0/appindicators-snapcraft-parts

While examples of indicators for various toolkits are
 - https://github.com/3v1n0/indicators-examples-snaps
Contributor

3v1n0 commented Jan 18, 2017

Reproposing this after snapcraft with proper remote indicators has been released

Owner

didrocks commented Jan 30, 2017

Looking good! However, we did merge now the GNOME desktop runtime as well. Do you mind looking at them if your PR doesn't need to change?
I think, for both Qt and GNOME desktop runtime, we don't want to have two depending part, but ensuring we have everything needed in the runtime and just embeeding everything in the platform snap, if that makes sense to you.

Contributor

3v1n0 commented Jan 30, 2017

Sure, let me check that...

Contributor

3v1n0 commented Feb 14, 2017

If we want to include indicator-gtk3 directly into the runtime, I guess this is fine to merge, isn't it?

Owner

didrocks commented Feb 15, 2017

Correct, that's fine by me (as you didn't set after: in the platform ones, which should be part of the runtime (but maybe package-based)). Merging! 👍

@didrocks didrocks merged commit aabeed6 into Ubuntu:master Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment