Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Write the .last_revision stamp under $SNAP_USER_DATA. #66
Conversation
added a commit
to lirios/platform-snap
that referenced
this pull request
Jun 28, 2017
|
I am a little bit vary about that one. Are you sure that the desktop launchers are working properly in a classic environment? I see multiple things, like relocatable home and so on which are incompatible with classic snaps where home is the real user's home. Why do you need the desktop launchers for classic? If it's just few libraries you embeeded, you shouldn't use any desktop-* parts, but just export LD_LIBRARY_PATH and such, wdyt? |
|
Well I started using the desktop helpers seeing that I had lots of duplicated code in my custom launcher, not just LD_LIBRARY_PATH exports. It might not be a great idea as you point out though, and in fact this prompts me to reconsider the use of classic confinement at all. In any case, that change should be harmless for strictly confined snaps, and if the desktop launchers are not meant to be used by classic snap I think this should be clearly documented, to avoid skewed expectations. |
|
You're right. Also, that was the only place I was using Thanks! |
oSoMoN commentedJun 28, 2017
This ensures the desktop launchers can also be used with classic snaps.