Add hexchat snap

[hikiko]

added hexchat to snappy playpen

---

This change is

[dholbach]

hexchat/README.md, line 1 [r1] (raw file):

# $PROJECT hexchat

Maybe "hextchat snap" instead?

---

Comments from Reviewable

[dholbach]

hexchat/snapcraft.yaml, line 4 [r1] (raw file):

version: 0.1
summary: IRC client for X based on X-Chat 2
description: HexChat is a graphical IRC client with a GTK+ GUI. Features include Python and Perl scripting support, a plugin API, multiple server/channel windows, spell checking, multiple authentication methods including SASL, and customizable notifications. For more information on IRC, see http://irchelp.org/.

You can use something like this to wrap the lines at 80 chars:

description: |
  HexChat is a graphical IRC client with a GTK+ GUI. Features include Python    
  and Perl scripting support, a plugin API, multiple server/channel windows,    
  spell checking, multiple authentication methods including SASL, and           
  customizable notifications. For more information on IRC, see                  
  http://irchelp.org/.

---


*Comments from [Reviewable](https://reviewable.io:443/reviews/ubuntu/snappy-playpen/171)*
<!-- Sent from Reviewable.io -->

[dholbach]

hexchat/snapcraft.yaml, line 13 [r1] (raw file):

        build-packages:
            - hexchat-common

Is this really required for building?

---

Comments from Reviewable

[dholbach]

hexchat/snapcraft.yaml, line 14 [r1] (raw file):

        build-packages:
            - hexchat-common
            - libc6

Are you sure not the relevant lib*-dev packages are needed?

---

Comments from Reviewable

[dholbach]

snap-template/README.md, line 0 [r1] (raw file):
Why is this deleted?

---

Comments from Reviewable

[dholbach]

snap-template/snapcraft.yaml, line 0 [r1] (raw file):
Why is this deleted?

---

Comments from Reviewable

[dholbach]

hexchat/snapcraft.yaml, line 14 [r1] (raw file):

Previously, dholbach (Daniel Holbach) wrote…

Are you sure not the relevant lib*-dev packages are needed?

https://travis-ci.org/ubuntu/snappy-playpen/builds/144407862 fails too. It will at least need `intltool` to pass this particular issue. Maybe take a look `apt-cache showsrc hexchat` to get an idea what it requires in Ubuntu to build?

---

Comments from Reviewable

[dholbach]

hexchat/snapcraft.yaml, line 14 [r1] (raw file):

Previously, dholbach (Daniel Holbach) wrote…

https://travis-ci.org/ubuntu/snappy-playpen/builds/144407862 fails too. It will at least need intltool to pass this particular issue. Maybe take a look apt-cache showsrc hexchat to get an idea what it requires in Ubuntu to build?

Maybe add `imagemagick, intltool, libcanberra-dev, libdbus-glib-1-dev, libglib2.0-dev, libgtk2.0-dev, libnotify-dev, libpci-dev, libperl-dev, libproxy-dev, libssl-dev, libtool, python-dev`?

---

Comments from Reviewable

[hikiko]

Thanks for the review :) I've fixed several things, I hope it looks better now.

[dholbach]

hexchat/snapcraft.yaml, line 17 [r4] (raw file):

            - liblua5.3-dev
            - libluajit-5.1-dev
            - debhelper

debhelper won't be needed.

---

Comments from Reviewable

[dholbach]

hexchat/snapcraft.yaml, line 4 [r1] (raw file):

Previously, dholbach (Daniel Holbach) wrote…

You can use something like this to wrap the lines at 80 chars:

description: |
  HexChat is a graphical IRC client with a GTK+ GUI. Features include Python    
  and Perl scripting support, a plugin API, multiple server/channel windows,    
  spell checking, multiple authentication methods including SASL, and           
  customizable notifications. For more information on IRC, see                  
  http://irchelp.org/.
</details>
Wrapping would look nicer, but not a big issue.

---

Comments from Reviewable

[dholbach]

snap-template/README.md, line [r1] (raw file):

Previously, dholbach (Daniel Holbach) wrote…

Why is this deleted?

It'd be nice if this could be re-added.

---

Comments from Reviewable

[dholbach]

snap-template/snapcraft.yaml, line [r1] (raw file):

Previously, dholbach (Daniel Holbach) wrote…

Why is this deleted?

It'd be nice if this could be re-added.

---

Comments from Reviewable

[tsimonq2]

version: "0.1"

[tsimonq2]

this doesn't make sense, or am I wrong?

[hikiko]

That's the short description that is returned by apt-cache search hexchat.

[tsimonq2]

Could you wrap at 80 chars please?

[tsimonq2]

this empty line isn't needed

[tsimonq2]

Could you change the indent from four (4) spaces to two (2) spaces please?

[dplanella]

Hm... the snap does not work for me:

$ hexchat 

(process:19463): Gtk-WARNING **: Locale not supported by C library.
    Using the fallback 'C' locale.
Gtk-Message: Failed to load module "overlay-scrollbar"
Gtk-Message: Failed to load module "gail"
Gtk-Message: Failed to load module "atk-bridge"
Gtk-Message: Failed to load module "unity-gtk-module"

(hexchat:19463): Gtk-WARNING **: cannot open display: :0

Have you tried using the desktop launcher? I can't work out how you are setting up the environment with just calling the binary and without a launcher.

[dplanella]

I've submitted a PR with some small changes, as once I got the app to launch, it wouldn't connect to the IRC servers: https://github.com/hikiko/snappy-playpen/pull/1

Also, it would be good to add an icon and a desktop file under the setup/gui directory (you can have a look at the other examples in the playpen to see how it's done).

[dplanella]

Thanks for adding the desktop launcher. I'm not sure if you saw the PR against your branch mentioned above, but at least on my case, I had to add the network-bind plug for hexchat to connect to IRC servers. It might be worth double-checking that.

[dholbach]

hexchat/snapcraft.yaml, line 3 [r5] (raw file):

Previously, hikiko (Eleni Maria S.) wrote…

That's the short description that is returned by apt-cache search hexchat.

I think it's fine.

---

Comments from Reviewable

[dholbach]

hexchat/snapcraft.yaml, line 2 [r5] (raw file):

Previously, tsimonq2 (Simon Quigley) wrote…

version: "0.1"

Not a blocker.

---

Comments from Reviewable

[tsimonq2]

why the extra line here?

[tsimonq2]

from what I've seen, the apps: tag usually goes above the parts: tag

[tsimonq2]

something picky, could you put network and network-bind together? So like this:

plugs: [network, network-bind, x11, unity7]

[tsimonq2]

@hikiko I think that unless you specify the snap in the snapcraft.yaml file, it should be HexChat, not Hexchat, hexchat, or HEXCHAT. That's the branding on their website.

[tsimonq2]

I would word it like:

Known issues: This snap currently uses a fork of hexchat (https://github.com/hikiko/hexchat) until

[tsimonq2]

pull request, not merge proposal. :)

[tsimonq2]

forked repository

[tsimonq2]

something picky that I usually do, change git:// to https:// because the protocol used in git:// isn't secure

[tsimonq2]

@hikiko this still needs to be fixed

[tsimonq2]

(there has been a pull request submitted) or (I have submitted a pull request)

[tsimonq2]

still needs to be fixed

[dholbach]

hexchat/snapcraft.yaml, line 36 [r13] (raw file):

Previously, tsimonq2 (Simon Quigley) wrote…

from what I've seen, the apps: tag usually goes above the parts: tag

It doesn't matter.

---

Comments from Reviewable

[dholbach]

---

Comments from Reviewable

[dholbach]

Reviewed 4 of 4 files at r1, 2 of 2 files at r2, 1 of 1 files at r4, 2 of 3 files at r5, 2 of 2 files at r7, 1 of 1 files at r8, 1 of 1 files at r12, 2 of 3 files at r13, 2 of 2 files at r17.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable