Clock snap running on Unity 7 and Unity 8 #179

Merged
merged 6 commits into from Jul 15, 2016

Conversation

Projects
None yet
2 participants
Collaborator

dplanella commented Jul 14, 2016

This snap should work on both versions of Unity.

clockunity8

Known issues:

  • For some reason, the .desktop file is not picked up on Unity 7. I've checked for typos, but I've not seen anything obvious.
  • On Unity 8 it needs to be installed with --devmode to work. Only in Unity 7 does it work with strict confinement.
  • On Unity 8 the icon does not appear on the launcher
  • On Unity 8 the icon does not appear in the Apps scope

This change is Reviewable

dplanella added some commits Jul 14, 2016

@dplanella dplanella changed the title from A new version of the clock app that works both on Unity 7 and Unity 8 to Clock snap running on Unity 7 and Unity 8 Jul 14, 2016

Collaborator

dplanella commented Jul 14, 2016

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.


ubuntu-clock-app/clock.wrapper, line 66 [r2] (raw file):


cd $SNAP
exec $SNAP/usr/bin/qmlscene $SNAP/usr/share/ubuntu-clock-app/ubuntu-clock-app.qml --desktop_file_hint=unity8

I added this as Unity 8 apps seem to use it, but I'm not sure about its function and if it has any effect on Unity 7


Comments from Reviewable

Collaborator

dplanella commented Jul 14, 2016

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions.


ubuntu-clock-app/snapcraft.yaml, line 6 [r2] (raw file):

description: The clock app for all Ubuntu devices
confinement: devmode

Changed to devmode, as otherwise it does not work under strict confinement in unity 8. Perhaps a unity8 interface is still missing?


Comments from Reviewable

Collaborator

dholbach commented Jul 15, 2016

ubuntu-clock-app/clock.wrapper, line 66 [r2] (raw file):

Previously, dplanella (David Planella) wrote…

I added this as Unity 8 apps seem to use it, but I'm not sure about its function and if it has any effect on Unity 7

Do you think you can add this as an XXX: to the wrapper or README so other who copy and paste this are aware of this? :-)

Comments from Reviewable

Collaborator

dholbach commented Jul 15, 2016

ubuntu-clock-app/snapcraft.yaml, line 6 [r2] (raw file):

Previously, dplanella (David Planella) wrote…

Changed to devmode, as otherwise it does not work under strict confinement in unity 8. Perhaps a unity8 interface is still missing?

Do you recall if there were any log messages?

Comments from Reviewable

Collaborator

dholbach commented Jul 15, 2016

ubuntu-clock-app/setup/gui/ubuntu-clock-app.desktop, line 134 [r2] (raw file):

Keywords[zh_CN]=time;alarm;alert;clock;world;stopwatch; 时间;闹铃;闹钟;世界时;秒表;
Keywords[zh_TW]=time;alarm;alert;clock;world;stopwatch;時鐘;鬧鐘;鬧鈴;世界;碼表;
Exec=ubuntu-clock-app.clock

I think this is ubuntu-clock-app now.


Comments from Reviewable

Collaborator

dplanella commented Jul 15, 2016

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.


ubuntu-clock-app/snapcraft.yaml, line 6 [r2] (raw file):

Previously, dholbach (Daniel Holbach) wrote…

Do you recall if there were any log messages?

Yes, on Unity 8, with strict confinement and using the unity7 plug it said it could not connect to the Mir server and coredumped. I've been told there was some initial work on a unity8 interface, but it's stalled: https://github.com/snapcore/snapd/pull/1229

ubuntu-clock-app/setup/gui/ubuntu-clock-app.desktop, line 134 [r2] (raw file):

Keywords[zh_CN]=time;alarm;alert;clock;world;stopwatch; 时间;闹铃;闹钟;世界时;秒表;
Keywords[zh_TW]=time;alarm;alert;clock;world;stopwatch;時鐘;鬧鐘;鬧鈴;世界;碼表;
Exec=ubuntu-clock-app.clock

Will fix it.


Comments from Reviewable

dplanella added some commits Jul 15, 2016

Collaborator

dplanella commented Jul 15, 2016

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.


ubuntu-clock-app/clock.wrapper, line 66 [r2] (raw file):

Previously, dholbach (Daniel Holbach) wrote…

Do you think you can add this as an XXX: to the wrapper or README so other who copy and paste this are aware of this? :-)

Done.

ubuntu-clock-app/setup/gui/ubuntu-clock-app.desktop, line 134 [r2] (raw file):

Previously, dplanella (David Planella) wrote…

Will fix it.

Done.

Comments from Reviewable

Collaborator

dplanella commented Jul 15, 2016

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.


ubuntu-clock-app/setup/gui/ubuntu-clock-app.desktop, line 134 [r2] (raw file):

Previously, dholbach (Daniel Holbach) wrote…

I think this is ubuntu-clock-app now.

Done.

Comments from Reviewable

Collaborator

dholbach commented Jul 15, 2016

:lgtm:


Comments from Reviewable

Collaborator

dholbach commented Jul 15, 2016

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@dholbach dholbach merged commit 8572940 into master Jul 15, 2016

2 checks passed

code-review/reviewable 4 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dholbach dholbach deleted the clock-unity8 branch Jul 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment