Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Clock snap running on Unity 7 and Unity 8 #179
Conversation
dplanella
added some commits
Jul 14, 2016
dplanella
changed the title from
A new version of the clock app that works both on Unity 7 and Unity 8
to
Clock snap running on Unity 7 and Unity 8
Jul 14, 2016
|
Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. ubuntu-clock-app/clock.wrapper, line 66 [r2] (raw file):
I added this as Unity 8 apps seem to use it, but I'm not sure about its function and if it has any effect on Unity 7 Comments from Reviewable |
|
Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions. ubuntu-clock-app/snapcraft.yaml, line 6 [r2] (raw file):
Changed to devmode, as otherwise it does not work under strict confinement in unity 8. Perhaps a unity8 interface is still missing? Comments from Reviewable |
|
ubuntu-clock-app/clock.wrapper, line 66 [r2] (raw file):
|
|
ubuntu-clock-app/snapcraft.yaml, line 6 [r2] (raw file):
|
|
ubuntu-clock-app/setup/gui/ubuntu-clock-app.desktop, line 134 [r2] (raw file):
I think this is Comments from Reviewable |
|
Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions. ubuntu-clock-app/snapcraft.yaml, line 6 [r2] (raw file):
|
dplanella
added some commits
Jul 15, 2016
|
Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions. ubuntu-clock-app/clock.wrapper, line 66 [r2] (raw file):
|
|
Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions. ubuntu-clock-app/setup/gui/ubuntu-clock-app.desktop, line 134 [r2] (raw file):
|
|
Comments from Reviewable |
|
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, 2 of 2 files at r3. Comments from Reviewable |
dplanella commentedJul 14, 2016
•
Edited 1 time
-
dplanella
Jul 14, 2016
This snap should work on both versions of Unity.
Known issues:
--devmodeto work. Only in Unity 7 does it work with strict confinement.This change is