Update hexchat snapcraft.yml #187

Merged
merged 2 commits into from Jul 22, 2016

Conversation

Projects
None yet
3 participants
Contributor

diddledan commented Jul 20, 2016

Update for smaller set of dependencies and tidy-up in-lined options. Also changed the snap build to using the released version tarball rather than the tip of git.

I've published a snap based on this configuration to the store for anyone to check-out: https://uappexplorer.com/app/unofficial-hexchat.diddledan

source:
plugin:
snap:
build-packages:
after:

We don't order them in ascii order, but in a logical one.

  

hexchat/snapcraft.yaml
@@ -1,6 +1,6 @@
name: hexchat
-version: "2.12.1"
-summary: IRC client for X based on X-Chat 2
+version: 2.12.1
@didrocks

didrocks Jul 21, 2016

Owner

We have as best practice to enforce version being in a string field. (that prevents if we update to "2.20" to be translated in "2.2". Please revert that change.

@diddledan

diddledan Jul 21, 2016

Contributor

👍

hexchat/snapcraft.yaml
+ - pulseaudio
+ - network
+ - network-bind
+ - home
@didrocks

didrocks Jul 21, 2016

Owner

This was less than 80 characters, same, as per our best practices, please leave current list in one line as it is for clarity.

@diddledan

diddledan Jul 21, 2016

Contributor

👍

hexchat/snapcraft.yaml
+ - pulseaudio
+ - network
+ - network-bind
+ - home
parts:
hexchat:
@didrocks

didrocks Jul 21, 2016

Owner

Same, as part of our best practices (sorry, that should be documented), the order here should be:

  source:
  plugin:
  snap:
  build-packages:
  after:

We don't order them in ascii order, but in a logical one.

@diddledan

diddledan Jul 21, 2016

Contributor

👍

diddledan added some commits Jul 20, 2016

Update hexchat snapcraft.yml
Update for smaller set of dependencies and tidy-up inlined options
Update README.md for hexchat
I've set hexchat as  for now, and linked to my unofficial build.
Collaborator

dholbach commented Jul 22, 2016

Nice work!

@dholbach dholbach merged commit d7fae4f into Ubuntu:master Jul 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment