Add the zsh snap #238

Merged
merged 7 commits into from Sep 21, 2016

Conversation

Projects
None yet
4 participants
Member

elopio commented Sep 14, 2016


  

zsh/README.md
@@ -0,0 +1,14 @@
+# Z shell snap
+
+This project creates a devmode working snap of the Z shell.
@tsimonq2

tsimonq2 Sep 15, 2016

Contributor

I would reword this.

zsh/snapcraft.yaml
+version: master
+summary: a shell designed for interactive use, and a powerful scripting language
+description: |
+ The Z-Shell, `zsh' for short, is a command interpreter for UNIX systems. zsh
@tsimonq2

tsimonq2 Sep 15, 2016

Contributor

mismatching single quotes

zsh/snapcraft.yaml
+ source: git://git.code.sf.net/p/zsh/code
+ plugin: autotools
+ install-via: prefix
+ build-packages: [yodl, libncursesw5-dev]
@tsimonq2

tsimonq2 Sep 15, 2016

Contributor

I would suggest reversing the two.

wrap-and-sort is nice and makes me think of these things. We need one for snaps. :D

Contributor

tsimonq2 commented Sep 15, 2016

@elopio nice work!

I haven't tested it, but I looked it over and it seems to be 👍 except for the comments I left.

Member

elopio commented Sep 21, 2016

Thanks for the review. I pushed the fixes.

Collaborator

dholbach commented Sep 21, 2016

Nice work! Merging!

@dholbach dholbach merged commit 520111c into Ubuntu:master Sep 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment