/snappy-playpen

Make sure that clock app appears on unity8 shell. #251

Merged
merged 1 commit into from Oct 10, 2016

Conversation

Reviewers

@dholbach dholbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@renatofilho @dholbach
@renatofilho

renatofilho commented Oct 7, 2016

  • Update desktop file with the correct values
  • Added qtorganizer5-eds as dep to get alarms working
ubuntu-clock-app/setup/gui/ubuntu-clock-app.desktop
@@ -132,7 +132,7 @@ Keywords[uk]=time;alarm;alert;clock;world;stopwatch;час;нагадуванн
Keywords[zh_CN]=time;alarm;alert;clock;world;stopwatch; 时间;闹铃;闹钟;世界时;秒表;
Keywords[zh_TW]=time;alarm;alert;clock;world;stopwatch;時鐘;鬧鐘;鬧鈴;世界;碼表;
Exec=ubuntu-clock-app
-Icon=${SNAP}/meta/gui/clock-app@30.png
@dholbach

dholbach Oct 10, 2016

Collaborator

Could we still use the ${SNAP} variable?

@renatofilho

renatofilho Oct 10, 2016

No, We need the real path of the icon. This desktop file is read from unity8 outside the SNAP enviroment.

ubuntu-clock-app/snapcraft.yaml
- mir-graphics-drivers-desktop
snap:
- -usr/share/doc
- -usr/include
+ after:
+ - desktop-gtk3
@dholbach

dholbach Oct 10, 2016

Collaborator

Why gtk3 and not qt5?

@renatofilho

renatofilho Oct 10, 2016

We need glib/gsettings paths and some environment initializations that is done by this launcher. This is necessary to communicate with EDS.

@dholbach

dholbach Oct 10, 2016

Collaborator

Oh ok.

@dholbach
Collaborator

dholbach commented Oct 10, 2016

Thanks for the update, merging!

@dholbach dholbach merged commit 3c14d64 into Ubuntu:master Oct 10, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@renatofilho renatofilho deleted the renatofilho:clock-unity8 branch Oct 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment