This repository has been archived by the owner on Jan 20, 2020. It is now read-only.
Make sure that clock app appears on unity8 shell. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatofilho
commented
Oct 7, 2016
renatofilho
commented
- Update desktop file with the correct values
- Added qtorganizer5-eds as dep to get alarms working
dholbach
suggested changes
Oct 10, 2016
| @@ -132,7 +132,7 @@ Keywords[uk]=time;alarm;alert;clock;world;stopwatch;час;нагадуванн | |||
| Keywords[zh_CN]=time;alarm;alert;clock;world;stopwatch; 时间;闹铃;闹钟;世界时;秒表; | |||
| Keywords[zh_TW]=time;alarm;alert;clock;world;stopwatch;時鐘;鬧鐘;鬧鈴;世界;碼表; | |||
| Exec=ubuntu-clock-app | |||
| Icon=${SNAP}/meta/gui/clock-app@30.png | |||
There was a problem hiding this comment.
Could we still use the ${SNAP} variable?
There was a problem hiding this comment.
No, We need the real path of the icon. This desktop file is read from unity8 outside the SNAP enviroment.
| - mir-graphics-drivers-desktop | ||
| snap: | ||
| - -usr/share/doc | ||
| - -usr/include | ||
| after: | ||
| - desktop-gtk3 |
There was a problem hiding this comment.
We need glib/gsettings paths and some environment initializations that is done by this launcher. This is necessary to communicate with EDS.
dholbach
approved these changes
Oct 10, 2016
|
Thanks for the update, merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.