Add octoprint #69

Open
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants

mariogrip commented Jun 16, 2016

Octoprint is an 3d printer controller with webUI, http://octoprint.org/


This change is Reviewable


- <img border=0 src='https://avatars.githubusercontent.com/u/1346979?v=3' height=16 width=16'> Oh, sorry about that. Let me try this properly now.

Comments from Reviewable

= AppArmor =
Time: Jun 21 11:17:38
Log: apparmor="DENIED" operation="open" profile="snap.octoprint.octoprint" name="/home/daniel/dev/snappy/snappy-playpen/octoprint/parts/octoprint/install/usr/lib/python2.7/os.pyc" pid=32185 comm="octoprint" requested_mask="r" denied_mask="r" fsuid=0 ouid=1000
File: /home/daniel/dev/snappy/snappy-playpen/octoprint/parts/octoprint/install/usr/lib/python2.7/os.pyc (read)
Suggestion:
* adjust program to read necessary files from $SNAP, $SNAP_DATA or $SNAP_USER_DATA

Does it need --devmode?

Comments from Reviewable

- <img border=0 src='https://avatars.githubusercontent.com/u/1346979?v=3' height=16 width=16'> It looks like it needs to be rebased on current master too.

Comments from Reviewable

  

Collaborator

dholbach commented Jun 16, 2016

The build fails AFAICS.

octoprint/snapcraft.yaml
+
+apps:
+ octoprint:
+ command: ./usr/bin/octoprint
@zyga

zyga Jun 16, 2016

usr/bin is on PATH so it will be found by default

@dholbach Fixed now :)

mariogrip added some commits Jun 17, 2016

+
+apps:
+ octoprint:
+ command: octoprint
@dholbach

dholbach Jun 17, 2016

Collaborator

This might need to be usr/bin/octoprint for it to work. Do you have octoprint in /snap/bin?

@mariogrip

mariogrip Jun 17, 2016

@zyga said

usr/bin is on PATH so it will be found by default

so i removed ./usr/bin with 9e83ecf

@mariogrip

mariogrip Jun 17, 2016

btw, I have tested it, and it works

Collaborator

dholbach commented Jun 20, 2016

It still doesn't work for me: http://paste.ubuntu.com/17589794/

@dholbach That's because of daemon: simple, to start it run sudo service snap.octoprint.octoprint start

Collaborator

dholbach commented Jun 21, 2016

Oh, sorry about that. Let me try this properly now.


Comments from Reviewable

Collaborator

dholbach commented Jun 21, 2016

= AppArmor =
Time: Jun 21 11:17:38
Log: apparmor="DENIED" operation="open" profile="snap.octoprint.octoprint" name="/home/daniel/dev/snappy/snappy-playpen/octoprint/parts/octoprint/install/usr/lib/python2.7/os.pyc" pid=32185 comm="octoprint" requested_mask="r" denied_mask="r" fsuid=0 ouid=1000
File: /home/daniel/dev/snappy/snappy-playpen/octoprint/parts/octoprint/install/usr/lib/python2.7/os.pyc (read)
Suggestion:
* adjust program to read necessary files from $SNAP, $SNAP_DATA or $SNAP_USER_DATA

Does it need --devmode?


Comments from Reviewable

Collaborator

dplanella commented Jul 14, 2016

@mariogrip have you had the chance to look at the questions on this PR? It'd be great to get octoprint added to the playpen, thanks! :-)

Collaborator

dholbach commented Jul 14, 2016

It looks like it needs to be rebased on current master too.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment