Mutt snap

[tsimonq2]

This adds a working Mutt snap.

---

This change is

•  General Comment

• <img border=0 src='https://avatars.githubusercontent.com/u/1823296?v=3' height=16 width=16'> Reviewed 2 of 2 files at r1.
  Review status: all files reviewed at latest revision, all discussions resolved.

  Comments from Reviewable

- <img border=0 src='https://avatars.githubusercontent.com/u/1823296?v=3' height=16 width=16'> Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

a discussion (no related file):

Can you add it to the main content table, please?

Comments from Reviewable

• <img border=0 src='https://avatars.githubusercontent.com/u/3689821?v=3' height=16 width=16'> @didrocks done

- <img border=0 src='https://avatars.githubusercontent.com/u/1823296?v=3' height=16 width=16'>

Reviewed 1 of 1 files at r2.

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

• <img border=0 src='https://avatars.githubusercontent.com/u/1346979?v=3' height=16 width=16'> mutt/README.md, line 8 [r1] (raw file):

  `Markdown

  Working features:

  • Fully functional it seems
    Not quite. The group creation will not work and access to files in~` won't be as straight-forward as in normal mutt. Maybe ask some real users to test?

  ---

  Comments from Reviewable

- <img border=0 src='https://avatars.githubusercontent.com/u/1346979?v=3' height=16 width=16'> I would hold off for now.

Comments from Reviewable

• <img border=0 src='https://avatars.githubusercontent.com/u/1346979?v=3' height=16 width=16'> mutt/README.md, line 8 [r1] (raw file):

  Previously, dholbach (Daniel Holbach) wrote…

  Not quite. The group creation will not work and access to files in ~ won't be as straight-forward as in normal mutt. Maybe ask some real users to test?

  Needs some discussion on the list to understand problems better. --- _Comments from [Reviewable](https://reviewable.io:443/reviews/ubuntu/snappy-playpen/98)_

- <img border=0 src='https://avatars.githubusercontent.com/u/1823296?v=3' height=16 width=16'> Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions.

a discussion (no related file):
Thanks for the changes!
As told on IRC, I think we shouldn't fork the autotools plugin from snapcraft but either:

• add some parameters with upstream to tweak the "make" commands

* or have that extensable by a dedicated plugin (which inherit from autools) which is changing only the "make" commands in fakeroot make ;)

Comments from Reviewable

• <img border=0 src='https://avatars.githubusercontent.com/u/3689821?v=3' height=16 width=16'> @didrocks how would I accomplish the latter? how would I inherit from the Autotools plugin but only tweak a tiny thing without forking?

- <img border=0 src='https://avatars.githubusercontent.com/u/1823296?v=3' height=16 width=16'> What you need to do is to propose a fix on the upstream autotools snapcraft plugin to make it configurable/inheritable that way (so that you can tweak each commands)

Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

• <img border=0 src='https://avatars.githubusercontent.com/u/1346979?v=3' height=16 width=16'> mutt/parts/plugins/autotoolscustom.py, line 6 [r4] (raw file):

  `Python

  class AutotoolscustomPlugin(snapcraft.BasePlugin):
  Could this inherit fromsnapcraft.plugins.autotools.AutotoolsPlugin` instead? This would probably avoid some of the duplication in here.

  ---

  Comments from Reviewable

• <img border=0 src='https://avatars.githubusercontent.com/u/1346979?v=3' height=16 width=16'> mutt/README.md, line 8 [r1] (raw file):

  Previously, dholbach (Daniel Holbach) wrote…

  Needs some discussion on the list to understand problems better.

  Apparently mutt is working for mvo? --- _Comments from [Reviewable](https://reviewable.io:443/reviews/ubuntu/snappy-playpen/98)_

• <img border=0 src='https://avatars.githubusercontent.com/u/3689821?v=3' height=16 width=16'> yes @dholbach

• <img border=0 src='https://avatars.githubusercontent.com/u/3689821?v=3' height=16 width=16'> @dholbach @didrocks How would I go about inheriting the autotools plugin then modifying the command to include fakeroot?

• <img border=0 src='https://avatars.githubusercontent.com/u/1823296?v=3' height=16 width=16'> you need to patch upstream snapcraft to be extendible for it IMHO.

• <img border=0 src='https://avatars.githubusercontent.com/u/1689781?v=3' height=16 width=16'> @tsimonq2 have you had the chance to look at this? Anything you need help moving this PR forward?

  

[didrocks]

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[didrocks]

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

a discussion (no related file):
Can you add it to the main content table, please?

---

Comments from Reviewable

[tsimonq2]

@didrocks done

[didrocks]

---

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[dholbach]

mutt/README.md, line 8 [r1] (raw file):

Working features:
 - Fully functional it seems

Not quite. The group creation will not work and access to files in ~ won't be as straight-forward as in normal mutt. Maybe ask some real users to test?

---

Comments from Reviewable

[dholbach]

I would hold off for now.

---

Comments from Reviewable

[dholbach]

mutt/README.md, line 8 [r1] (raw file):

Previously, dholbach (Daniel Holbach) wrote…

Not quite. The group creation will not work and access to files in ~ won't be as straight-forward as in normal mutt. Maybe ask some real users to test?

Needs some discussion on the list to understand problems better.

---

Comments from Reviewable

[didrocks]

Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions.

---

a discussion (no related file):
Thanks for the changes!

As told on IRC, I think we shouldn't fork the autotools plugin from snapcraft but either:

• add some parameters with upstream to tweak the "make" commands
• or have that extensable by a dedicated plugin (which inherit from autools) which is changing only the "make" commands in fakeroot make ;)

---

Comments from Reviewable

[tsimonq2]

@didrocks how would I accomplish the latter? how would I inherit from the Autotools plugin but only tweak a tiny thing without forking?

[didrocks]

What you need to do is to propose a fix on the upstream autotools snapcraft plugin to make it configurable/inheritable that way (so that you can tweak each commands)

---

Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions.

---

Comments from Reviewable

[dholbach]

mutt/parts/plugins/autotoolscustom.py, line 6 [r4] (raw file):

class AutotoolscustomPlugin(snapcraft.BasePlugin):

Could this inherit from snapcraft.plugins.autotools.AutotoolsPlugin instead? This would probably avoid some of the duplication in here.

---

Comments from Reviewable

[dholbach]

mutt/README.md, line 8 [r1] (raw file):

Previously, dholbach (Daniel Holbach) wrote…

Needs some discussion on the list to understand problems better.

Apparently mutt is working for mvo?

---

Comments from Reviewable

[tsimonq2]

yes @dholbach

[tsimonq2]

@dholbach @didrocks How would I go about inheriting the autotools plugin then modifying the command to include fakeroot?

[didrocks]

you need to patch upstream snapcraft to be extendible for it IMHO.

[dplanella]

@tsimonq2 have you had the chance to look at this? Anything you need help moving this PR forward?