Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing squircle icons for major open source apps like Inkscape, Gimp, Chromium? #1083

Closed
ubuntujaggers opened this Issue Jan 6, 2019 · 55 comments

Comments

Projects
None yet
5 participants
@ubuntujaggers
Copy link
Contributor

ubuntujaggers commented Jan 6, 2019

I think we now have a squircle icon for all apps that are installed by default - what about non-default apps that a lot of users install straightaway?

While we wait for the full script solution - should we put some of the most popular apps on squircles like we did with Firefox and Thunderbird? I was thinking Gimp, Inkscape and Chromium for starters...?

@eaglersdeveloper

This comment has been minimized.

Copy link
Contributor

eaglersdeveloper commented Jan 6, 2019

An icons of third-party applications shouldn't be in Yaru. They must be created by developers and be built into in their applications. We already have a few third-party application icons. Let's stop.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 6, 2019

Hm, I agree with @eaglersdeveloper a bit

I could think of gnome apps as an absolute ultra stop limit (Gimp, inkscape, etc.) but since there is that big icon overhaul on the way I don't think it is really necessary
http://jimmac.musichall.cz/stuff/icon-revolution/
Tbh they do not fit perfectly into the new ubuntu style, but they are for sure better than the current pseudo realistic gnome icons

Too reduce the optical gap between our icons and third party and/or gnome app icons, we could try to de-squircle some suru app icons, like @ubuntujaggers did with the symbolic icons. just an idea 🤷‍♂️ Only de-squircle if it works

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 6, 2019

With de-squircling I mean

  1. keep the suru folding style, make it still look like origami
  2. bring some variation into the icon shapes, thus destroying the desire to surufy every icon on the planet.... very bad example but something "like this" for every app icon
    image
    Another bad example... a different icon theme... totally different style but to show that it does not have the problem to look "alien" beside "none-squircly" icons
    image
@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 6, 2019

Origami has ofc also many shapes and has not a rule to make everything a squircle
( https://i-ref.de/iref-impuls/nur-ein-blatt-papier-atemberaubende-origami-kunst-von-gonzalo-garcia-calvo/ )
As long as we keep the current origami style we could try to de-squircle our icons. If that is too much work I would ofc understand

@eaglersdeveloper

This comment has been minimized.

Copy link
Contributor

eaglersdeveloper commented Jan 6, 2019

This is bad idea.

Better to close this issue :)

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 6, 2019

Okay and why is it a bad idea to de-squircle the base shapes?
Origamis are not squircles.
The unified base shape creates the original problem. It creates the desire to surufy every icon.
Would be awesome if you could try to improve your communication skills. 🤕

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 6, 2019

I think it's definitely worth ongoing discussion - whether we chat in this Github issue or on discourse.ubuntu.com or wherever :)

Personally I'm a fan of squircles. But if the design team elects to make the shapes more varied, the amount of work isn't a problem and I can draw some. The device icons show that you can do Suru designs in a non-Suru way.

Rhythmbox would be a good example, as you suggest, because you could restore the classic stand-up speaker shape. It might be possible to do that by copying the proportions of the keyboard device icon exactly, only rotated through 90°, rather than slightly deforming the squircle.

Speaking purely personally... looking at your link, my preference would be to take the new Gnome icons as our reference point and do Suru versions of all the third party apps in that list, matching them icon for icon. If they can do their own icons for GIMP and Inkscape, then it must be permissible for us to redraw the same apps using squircles, like we did with LibreOffice. And matching the Gnome icon set might be an achievable ambition for us (whereas trying to do every app in the app store isn't). But that's just my personal opinion, speaking as a squircle fanatic :) and I'm happy to draw non-squircular icons if that's what the design team agrees on.

@eaglersdeveloper

This comment has been minimized.

Copy link
Contributor

eaglersdeveloper commented Jan 6, 2019

Speaking purely personally... looking at your link, my preference would be to take the new Gnome icons as our reference point and do Suru versions of all the third party apps in that list, matching them icon for icon.

GNOME application icons (not Adwaita) is licensed under GPL. We can't just take and use them in Yaru.

@eaglersdeveloper

This comment has been minimized.

Copy link
Contributor

eaglersdeveloper commented Jan 6, 2019

Would be awesome if you could try to improve your communication skills.

I dreaming about this.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 6, 2019

Yes discussion is welcome indeed!

When you put a square a circle and a triangle beneath each other, a hexagon doesn't suddenly look out of place.

Whereas when you put 4 exact squares beneath each other and you then add a triangle it looks out of place.

And that is the basic problem you have with uniform icon shapes.
Ofc they look great, I totally love the Suru icons. Especially the thin and elegant symbolic icons. I would even say Yaru really needs them as part of its identity.

De-squircling was just an idea. Let's see what @madsrh and @clobrano say

And as Didier already said as long as we don't ruin anY license we can Surufy any icon we like. It's not like we violate against any law or something ;D

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 6, 2019

@eaglersdeveloper ofc we can. That's what GPL is about. As long as we document the license correctly

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 6, 2019

(For clarity, when I said "match them icon for icon", I meant: if they have a Gnome icon for an app, then we have a Suru icon for the same app. I didn't actually mean taking their designs :) - although as Feichtmeier points out that would actually be permitted if we did it correctly.)

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 6, 2019

When you put a square a circle and a triangle beneath each other, a hexagon doesn't suddenly look out of place.

Whereas when you put 4 exact squares beneath each other and you then add a triangle it looks out of place.

You're quite right - this is why I have such high hopes for the squircles script, which is my favourite solution in the long term, because it means we can have my beloved squircles and everything is still uniform :)

@madsrh

This comment has been minimized.

Copy link
Member

madsrh commented Jan 6, 2019

To be honest, I'm a bit torn on this topic. Although I really like the new Suru Firefox icon, I'm still not used to it and I'm not sure I ever will prefer it over the upstream icon (maybe it's still just the background color 🤷‍♂️ ).

@Feichtmeier suggested to have all the icons that is installed by default in the dock, be suru styled. That was a realistic goal, but in the end we will always have mixed icons because users will run Spotify, Chrome, Telegram, Atom and so on.

The script solves that. @clobrano has there been any progress since this comment regarding the script?

Looking at my Window 10 and OSX desktop icons, it's a mixed bag too.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 6, 2019

@madsrh

"Although I really like the new Suru Firefox icon, I'm still not used to it and I'm not sure I ever will prefer it over the upstream icon."

I haven't been able to use it live yet - I can't get snaps to work since I upgraded to Cosmic, so I can't comment on this one (I might try replacing the icons manually).

IMO Firefox was a hard icon to do because our hands were tied in terms of altering the colours and design even slightly to adapt them to the theme. So it was literally a case of finding the least objectionable colour for the squircle, and even that was hard because Firefox has quite lurid colours and the Ubuntu dock is dark.

LibreOffice ended up being a lot easier because we had the freedom to adapt the pictogram to Suru colours and shapes as long as it was still recognisable.

IMO, open source apps like Inkscape could be more like a LibreOffice experience than a Firefox experience for us, because we have the freedom. I might groan a bit inside if there was another Firefox to do :P but would enjoy at least trying Inkscape etc.

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Jan 6, 2019

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 6, 2019

I fear that the new style of the gnome app icons do not fit to this theme project : /
They have a very specific style (lightly leveled, no border, a bit "toy-like").
http://jimmac.musichall.cz/stuff/icon-revolution/
Some icons are even very hard to recognize as what they are (for example "Icon preview")
image

Especially the symbolic icons are very thick and ruin the sharp and sleek look of yaru a bit.

If we would consider upstream icons, we really must keep the yaru symbolic icons. It is a very important part of the look. Like the ubuntu font. But honestly, I think this would be a bad idea. The level of sharpness and professional look of the suru icons is really not reached by these new icons - sorry. And it looks like the "design" progress is already done, so I see not much room to interact into these new icon guidelines.

It is linux so we have the choice - why shouldn't we chose?

My biggest favorite would be the none-squircle-yaru icon version, even if it is a shitload of work

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 6, 2019

Well I feel like consensus is building against putting everything on squircles :P but this is what I'd started doing as a WIP for a possible approach to Inkscape. It's basically just the flat version of the logo with Suru palette/drop shadow/highlight:

image

@clobrano, if I understand correctly, the Ruby script for the symbolic icons is working with svgs... if the current Surufy script will stop working, is the general idea of having "some" script still viable? I seem to vaguely remember that the change to svg introduced a problem with permissions for a particular folder, but I can't remember where I read that or if I just dreamt it.

Or... is it more the case that the mood in the design team is moving towards abandoning the uniform shape for app icons, because it's more trouble than it's worth? Sounds like you and @feictmeier are open to exploring this (if by "the Gnome approach" you mean non-uniform shapes) and @madsrh has mixed feelings about the success/wisdom of putting Firefox on a squircle?

If so: should I try desquircle-ising a couple of app icons as a starting point for discussion?

You know what... just an idea... but maybe Joey Sneddon would run a poll on OMG! Ubuntu!, as a sort of "advisory referendum". We could show what icons we've got coming in 19.04 - highlighting examples like Firefox, Thunderbird, LibreOffice - maybe add some concept art like Inkscape - and basically find out how much Ubuntu users like squircles versus other options?

EDIT: I suppose the problem with a poll is you look bad if you don't do what it says, lol.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 6, 2019

I just love your attitude @ubuntujaggers ! ❤️

I don't think that public polls can help us with making the right decision. Polls on the hub often didn't help (dialogues).

Tbh I would love to see a de-squircled approach but I don't want to force anything here.

I think everyone loves the suru icons from the "look"-point of view.
The problem is rather the "square, square, square, triangle" situation ;)

In the end, if we keep the current contributors to yaru for icons, where is the problem to maintain a parallel icon set to those new toy-like/candy-like gnome icons? If squircle or de-squircled, gnome has not many up-to-date and "current" apps. As you can see on that website I linked two times now. It is a lot less work than ... let's say.. a complete icon set for android 🙈

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 6, 2019

@Feichtmeier suggested to have all the icons that is installed by default in the dock, be suru styled. That was a realistic goal, but in the end we will always have mixed icons because users will run Spotify, Chrome, Telegram, Atom and so on.

Indeed! I think speaking of ubuntu - as a distributions for the Linux "masses" - default-installed-apps vs real third party apps (commercial apps) is a far bigger problem than suru icons vs gnome icons.
The "square, square, square, triangle" situation is present for ubuntu users when they install apps like spotify, telegram, vscode, skype, etc.
Or bitwigs, waveform, chrome, etc etc

iOS and even ubuntu phone devs can "force" the app devs to provide a certain icon shape, because those apps are only used in one "style-environment". The rules are set, there is not much room. So a forced shape is no problem.

In the Linux Desktop land this is a different story. "GNOME-users" (i.e. ubuntu users/fedora users) install kde apps, gnome apps, electron apps, whatever they want and need. Kde users vice versa
So a forced shape is problematic.

@eaglersdeveloper

This comment has been minimized.

Copy link
Contributor

eaglersdeveloper commented Jan 7, 2019

Since MIUI 9, Xiaomi preinstall two icon themes.

First is shaped:

Second vice versa:

We also can preinstall in Ubuntu two icon themes like in MIUI. User will can change icons in GNOME Tweaks.

@eaglersdeveloper

This comment has been minimized.

Copy link
Contributor

eaglersdeveloper commented Jan 7, 2019

New messaging-app icon might look like this:
messaging-after

@eaglersdeveloper

This comment has been minimized.

Copy link
Contributor

eaglersdeveloper commented Jan 7, 2019

settings-app:
settings-app-after

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 7, 2019

Awesome! That looks really good imho !
I don't know if two icon themes are a good idea though. We already have adwaita+ Yaru preinstalled.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 7, 2019

These look lovely!

Tbh, because the Suru palette is light and the default launcher is dark, you could probably remove the squircle from almost every Suru icon which has a pictogram on a squircle (rather than being a squircle-shaped object) and the resulting icons would look great, like these do.

For me, it would be a tiny bit sad because the dark launcher with bright squircles is what I picture when I think "next gen Ubuntu", ever since I had my BQ Aquarius Ubuntu Phone. And a launcher with squircles has been part of my Ubuntu desktop since Unity days (because I never ran that script to flatten it). I don't know any other desktop with squircle buttons and it's a nice visual differentiator for Ubuntu if we can get it to work.

But, as you demonstrate, it's possible to remove squircles with attractive results, if that's what we want to do instead.

For me, the key question is: do we have confidence that it will eventually be possible to add squircles to icons automatically? This could either be a script or a shell extension with a launcher change (or just the latter if we don't mind a mix in the app grid).

I feel that a script should be possible for svgs because each is stored as xml, so it could just be a case of performing text operations. If we don't already have an svg expert, I'm happy to study them and try to work out what steps a script would have to perform to scale/reposition the existing icon and put a squircle behind it, by adding to and changing the xml.

If we do have confidence that we can do this in future, I think the only reason to abandon squircles is if we think Ubuntu will look better without them.

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Jan 7, 2019

I feel that a script should be possible for svgs because each is stored as xml, so it could just be a case of performing text operations.

I'm sure it would be possible, I just don't know how yet 😄
It will probably be a bit trickier in the transition from all png to all svg, since we're going to have mixed icons that need to be managed differently

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 7, 2019

There is a setting in dash to dock which adds a colored background to the app icon (even without glossy)

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 7, 2019

I'm sure it would be possible, I just don't know how yet 😄

This I might be able to help with... I don't have any scripting, but I looked at svg xmls a couple of times to diagnose problems and could go further into it to work out what the script would have to do and document steps.

I feel like the major steps would be:

  • Scale the svg to 192x192px. I think you would do this by multiplying every lat and long for every point by x, where x is derived from the ratio of the icon's original size to the new size. If there are any non-square svgs, you might have to handle lat and long separately or add a padding value of y to the shorter dimension or something. So, we could study the structure of the XML and break this step down into a series of specific operations. Alternatively... I bet someone's already done this before and we could take it off the shelf :)

  • Convert the xml for the whole svg into a group of objects that could be inserted into another svg. This is hopefully as simple as deleting material from the start/end of the XML to leave just the objects. The resulting xml of shapes would be the "pictogram".

  • Insert the pictogram objects into a 256px svg that already has the Suru squircle. The pictogram group should be centred and put in a separate layer that's higher than the squircle layer. If we've scaled the original icon to 192px, I think centering would be as simple as adding 32 to each lat and long in the inserted group.

  • Recolour the Suru squircle. This might be a case of creating a throwaway png just so you can use the same tools as before to pick the shade. Then we insert the #00000 for that shade into specific known parts of the XML. We can generate two very similar shades and insert them into a gradient for maximum Suru.

But, of course: I don't want to keep pushing squircles if the design team is coming round to the idea that they just aren't necessary. @eaglersdeveloper has confirmed that we can make a set of very attractive non-uniform Suru icons, so I can see that's also an option.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 7, 2019

As far as I understood @clobrano correctly the script currently has no solution to snapped and flatpaked applications/application icons. Most snaps don't use the relative path icon name (some do). So they use an icon which is stored in the snap directories and I think the script is not allowed to manipulate that.

A dash to dock backlight solution would be universal. But then we should have no squircles around the pictorgrams because otherwise we end up with squircles within squircles (squircleception ;D)

Currently I don't find this option in dashtodock but it was included once
https://youtu.be/TMkBy0e2ZiY
Also without the glossy effect

DO NOT install dashtodock in ubuntu, currently it destroys the dock settings and you need some didier skills to restore the ubuntu dock :)

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 7, 2019

@Feichtmeier

"As far as I understood @clobrano correctly the script currently has no solution to snapped and flatpaked applications/application icons. Most snaps don't use the relative path icon name (some do). So they use an icon which is stored in the snap directories and I think the script is not allowed to manipulate that."

Ah, that was the bit I vaguely remembered, and wasn't sure whether I'd read it or dreamed it :) Thanks for the reminder.

I think you could make the launcher backlight exactly the same size proportions as the Suru squircle, and then you wouldn't get squircle-ception for existing Suru icons because the icon would exactly cover the backlight? But it would certainly mean you don't have to include a squircle for future Suru icons that are just going to be a pictogram on a plain squircle.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 7, 2019

@ubuntujaggers

and then you wouldn't get squircle-ception for existing Suru icons because the icon would exactly cover the backlight?

No, currently with our icon set we would have a squircle-ception (my god all those words... de-squircling... squircle-ception...) for pre-installed apps. We have some room for margin/padding in the dock styling though.
But I think the backlight would work best with a de-squircled Origami/Yaru-set
Would be awesome if you and/or @eaglersdeveloper could create a bunch of fastly-mocked-up de-squircled origami icons which could then be placed inside a mocked-up picture with a dock. So maybe the idea isn't so good like it is in my head but I would need to see it first. My inkscape skills are so crappy that everything looks like a bad idea if I would try to mock it up :)

Edit: we can also change the border-radius of the app icon background in the dock (the roundness of the background)

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Jan 7, 2019

@eaglersdeveloper

This comment has been minimized.

Copy link
Contributor

eaglersdeveloper commented Jan 7, 2019

new-icons

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 7, 2019

@Feichtmeier

"Would be awesome if you and/or @eaglersdeveloper could create a bunch of fastly-mocked-up de-squircled origami icons which could then be placed inside a mocked-up picture with a dock."

Yep, no problem :)

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 7, 2019

@eaglersdeveloper
Wow I think this looks very good and still very much like pieces of paper - which is the initial idea of origami like icons, right?
This would eliminate the square, square, square, triangle problem for sure. Could you show a picture with commercial apps in between?

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 7, 2019

Here are a couple more:

circle help app
non squircle ubiquity

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 7, 2019

I think that's enough icons to mock up a non-squircle Suru launcher at normal resolution that woud be real enough to make a decision, because it's a good mix. You have:

  • Non-squircle Suru icons that are pictograms with no background (music and settings);
  • Non-squircle icons that are solid non-uniform shapes: circles (clock, web, help), squares (ubiquity) and non-geometric (messaging);
  • ...and you could mix in upstream third party icons for Firefox, Thunderbird and (say) Gimp for realism.

If we did that at 1:1 resolution as a full screen mockup I think people could make a decision on choosing this option?

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 7, 2019

If we did that at 1:1 resolution as a full screen mockup I think people could make a decision on choosing this option?

Yes that should be a good idea. Like "a real screenshot" with a mix of pre installed apps and post installed apps from various sources

Some modern icons couldn't also not hurt like Spotify, Skype, vscode and do on

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 7, 2019

This is definitely not meant to sound negative, it's just food for thought: if we do abandon the idea of uniform Unity 8-style squircle icons... do we actually need to make/maintain our own icon theme for Yaru? This might be a good moment to ask that question even if the answer is "yes".

There must be a lot of good usable "paper-y" themes out there that could theoretically ship with Ubuntu. I'm sure a lot of icon designers would be delighted if their set were chosen as the new official icon theme for Ubuntu, and we could always work with an upstream maintainer if upstream were active.

I've never used Papirus so I don't know how much I'd like it, or whether it gels properly with Yaru, but I know it's popular:

image

...and there must be some beautiful icon themes out there in styles that would nicely complement Yaru.

So, I guess my open question is: do we remember why Suru was chosen in the first place, when there are more complete icon sets available? And does the original choice of Suru still make sense if we're going to radically fork it and take squircles out?

I suppose it's a bit like choosing a rare car because you like the idea of driving it, but upgrading it more and more because it's inconvenient... until it slowly starts to look and feel less unique. At some point, you pause to reconsider whether you're getting enough benefit to justify the inconvenience.

EDIT: That does sound really negative lol, I definitely want to carry on making icons for Ubuntu, but I think radically changing direction on Suru is a good point to ask that question.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 7, 2019

@ubuntujaggers

Well papirus looks a lot different imho. It uses other colors, other shades, other highlights. It looks a lot more "comic"-like. I agree that you have a point, but I'd say if we would decide to drop fullcolor suru icons, we should rather use the new adwaita icons (we need suru symbolic icons!).
Let's wait for @madsrh and @clobrano
Currently there are three ideas in this issue

  1. Keep as is and advance to some more squircle icons
  2. Remove squircle background shape and keep a fullcolor icon set for X icons
  3. Remove all fullcolor suru icons but keep the symbolic icons for the "slim" yaru look in headerbars etc
    and just use upstream fullcolor icons
@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Jan 7, 2019

if we would decide to drop fullcolor suru icons, we should rather use the new adwaita icons

I suppose it's a bit like choosing a rare car because you like the idea of driving it, but upgrading it more and more because it's inconvenient... until it slowly starts to look and feel less unique. At some point, you pause to reconsider whether you're getting enough benefit to justify the inconvenience.

I think both are very good points.

I really like this mockup and I'd be tempted to follow it, however we (I meant the Yaru team) didn't choose Suru iconset, so it shouldn't be our decision to drop it as well.

What is the real problem we are facing? The fact that non-suru icons look weird if we have many Suru icons? It could be (for sure) solved with the scripting (if we decide to keep on that direction).

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 7, 2019

What is the real problem we are facing?

It is not a big problem but a concern I have read some times "on the internet" by various "users" that the ubuntu icons are currently "incomplete". This comes from the fact that there are some icon sets around that really have hundreds and hundreds of app icons in their set and thus create the illusion to be complete (which gets destroyed in the moment you install snaps and flatpaks because icon sets can't target them)
So we end up with the "square square square triangle" situation which bothers some, but some just don't give a damn.
I thought a good target would be to provide suru icons for every app preinstalled in ubuntu. But then the user installs spotify snap or whatever and you have the "square square square triangle" situation again. 🤷‍♂️
Here I wrote down three possible solutions: #1083 (comment)
A fourth would be just to close this issue and move on :)
And a fifth would be the script. But are you sure that you can target flatpaks and snaps with the script @clobrano ?

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 7, 2019

First attempt at mocking up a larger launcher with the default launcher opacity and a mix of non-squircle Suru/3rd party icons (sorry the colour went slightly naff on upload...):

image

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 7, 2019

we (I meant the Yaru team) didn't choose Suru iconset, so it shouldn't be our decision to drop it as well.

Ah, that I didn't know.

Don't get me wrong, I love Suru and would love to carry on doing them with squircles and would love for the script to swoop in and squirclify the remainder, that's my fond hope. But, whatever Ubuntu ultimately decides to go with, I'm happy to help with any svg work that's needed in support of it.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 7, 2019

@Feichtmeier

"I thought a good target would be to provide suru icons for every app preinstalled in ubuntu."

I think it was a very sensible target - I just wondered if carrying on in the same way for some of the top third party apps would be a good "stretch goal" :) Doing the same apps that Gnome is doing is IMO very achievable - just need to work out the squircles situation.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 7, 2019

Tbh I would not see a problem to provide icons for open source apps from gnome.
In adwaita the situation is different: they make icons for adwaita and with the same guidelines all the gnome app icons are updated but they ship with the app and not with the adwaita set

@eaglersdeveloper

This comment has been minimized.

Copy link
Contributor

eaglersdeveloper commented Jan 9, 2019

Honestly, I didn't get used to new icons.
Now I find an application worse than before.

2019-01-09 15-17-48

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 9, 2019

Hm... yeah. Was just an experiment. Maybe we should just keep everything as it is and add some open source icons.

@eaglersdeveloper

This comment has been minimized.

Copy link
Contributor

eaglersdeveloper commented Jan 9, 2019

No no no. So we will become second-class distribution like Manjaro or MX Linux.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 9, 2019

Alright, though that comment is highly exaggerated and dramatized, let's just keep everything as it is (Squircles, PNGs). That way we can see if the surufy script works as a solution (snaps, flatpaks?).

@eaglersdeveloper

This comment has been minimized.

Copy link
Contributor

eaglersdeveloper commented Jan 9, 2019

I vote for squares, but not for raster icons.
By the way, "squares" are spelled correctly.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 9, 2019

It's a Yaru word: square + circle = squircle ;D

And we agreed that we like the idea of the SVG only app icons at some point in the future. Now that Jaggers branch is almost merged we are one step closer. If you like we could keep PNGs for now but let the 48 icons also use the bigger icon types without the fat highlights. Would that be okay for you as a mid-term solution?

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 9, 2019

That would certainly be faithful to how Ubuntu will look when we switch to svg. It will also highlight if any of the full size icons look blurry at 48px so we can consider tweaking the full size icon.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 9, 2019

No it is basically the other way around: the biggest icons (256x256) are scaled down and used until you tick the dock icon size below 34. Then they use the next size. I just make a PR and we test it. I am pretty sure we don't get everything right from the start anyways so we can comment in there :)

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 18, 2019

@ubuntujaggers we agreed (on telegram) that we want to target this (rather madness) gate of a complete icon set, ofc totally dependent on you and your commitment. So let's close this issue here and feel free to open individual pull requests for icons (we could start with the gnome apps from that adwaita icon grid) :) I'm curious with what you come up with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.