Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trash / Rubbish Bin doesn't look like a trashcan #1170

Closed
madsrh opened this Issue Feb 10, 2019 · 63 comments

Comments

Projects
None yet
9 participants
@madsrh
Copy link
Member

madsrh commented Feb 10, 2019

I've always felt that this icon doesn't remind me very much of a trashcan:
image

The current icon reminds me more of a mailbox:
image

Could we (@ubuntujaggers or @eaglersdeveloper ) draw a new one using a similar metaphor to the symbolic icon? This would also fix #868
image

image

Random inspiration from the internet:
image

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Feb 10, 2019

Yes please!

@meetdilip

This comment has been minimized.

Copy link

meetdilip commented Feb 11, 2019

This is what I use for my personal icon theme

trash

@Fredorn

This comment has been minimized.

Copy link

Fredorn commented Feb 11, 2019

This is what I use for my personal icon theme

trash

Nice ! ;)

@DanyGee

This comment has been minimized.

Copy link

DanyGee commented Feb 21, 2019

I really like the new trash icon - it blends with the new theme very well. I hope it will not get changed.
Btw, funny how tastes differ.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 21, 2019

I really like the new trash icon - it blends with the new theme very well. I hope it will not get changed.
Btw, funny how tastes differ.

Tbh, I like the current icon as well. As per the logo, it's based on a recycling bin (which is often blue, especially for paper) rather than a traditional metal bin. Obviously it will be different from country to country, but, in the UK, I haven't seen one of these:

image

...since the 1980s. So the blue recycling bin feels a bit more up-to-date, and I think it's a nice colour.

I think I'm right in saying that Windows uses the same symbolism of a square tub with a recycling logo, but with the blue/white inverted?

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Feb 22, 2019

Probably the reference for current trash icon is this one
image

:)

but as for the shopping bag, 3D-ish icons looks a bit odd in this Yaru set

we could also consider this
image

which is probably easier to made using the new shapes

@madsrh

This comment has been minimized.

Copy link
Member Author

madsrh commented Feb 22, 2019

we could also consider this

+1 yes, Humanity (again) had this one

I haven't seen one of these .since the 1980s. So the blue recycling bin feels a bit more up-to-date, and I think it's a nice colour.

I have never seen that blue trashcan, but perhaps it's a geographic thing. Anyway, the take away in this issue is that the current trash bin doesn't look like a trash bin (outside UK) and design that we decide to go with (blue bin, 80' garbage can or a paperbasket) it has to match the symbolic icons 🗑

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Feb 22, 2019

As some people pointed out it's a combination of wrong 3d usage in a theme that has no other 3dish icon plus the blue that looks very un-yaru-ish

@DanyGee

This comment was marked as off-topic.

Copy link

DanyGee commented Feb 22, 2019

Leave the current trashcan icon alone - its a great, modern design.
To all critics here:
Open Inkscape (or whatever) and post your wonderfull designs here - lets see how easy is to create a nice, yaru-ish trashcan icon 😄
Don't forget it has to look good in 16px too 😉

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 22, 2019

I've got an idea for something, might be tomorrow though (busy day!).

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Feb 22, 2019

@DanyGee you are basically almost alone in fanboying this trash can.

You don't have to tell anyone here what we need to leave alone. How about you leave this repo alone, we don't need people with such aggressive attitude here.

@DanyGee

This comment has been minimized.

Copy link

DanyGee commented Feb 22, 2019

This is still an open discussion, so anyone can post his own opinion and everyone has to respect it.
I just have enough of empty criticism from ppl that criticize someones professional, hard work, comparing it to some obsolete designs, and (what is the worst) don't show their own proposals.
You know, talk is cheap, as always.
Wan't a better trashcan icon? Create one! See how hard it is, experience what you have take into account creating it. Maybe you will understand this way why the new traschan icon looks like this.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Feb 22, 2019

Do you realize that we contribute to this repo since Novemeber 2017? What the hell!

@DanyGee

This comment has been minimized.

Copy link

DanyGee commented Feb 22, 2019

Really? Thats nice, so let me see your proposal for the best trashcan icon 👀 Don't waste your precious time arguing.

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Feb 22, 2019

Wan't a better trashcan icon? Create one!

Correct, this is actually a thread talking about creating new stuff. Stop complaining on people openly discussing on how to proceed. Many things are hard to do, that does not mean they can't be criticized.

Now, please everybody stops wasting time

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Feb 22, 2019

Don't waste your precious time arguing.

let me see your proposal

Leave the current trashcan icon alone

Create one!

Maybe you will understand

Look, I don't know who you are or what ever you contributed to this project (or any other open source project) other than 4 disrespectful comments in one issue, but what you definitely don't need and can't is telling me or us what and how we organize, discuss and finally contribute in this repository.

It is perfectly fine to express your preference for the current trashcan, which you did, and we recognized. So thank you very much for your "contribution".

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 22, 2019

This is what I wanted to try - the only rubbish receptacle I can think of that matches one of the core Suru shapes is a pedal bin, and this is my first attempt:

image

Also tried it in grey (silver) - IMO it looked drab for Yaru.

@DanyGee, this is the Github for the default Ubuntu theme and this is where the theme and new icons get made. There always has to be discussion before people start making new icons. Sometimes the discussion leads to something better, sometimes it doesn't. As much as I like the current icon, it isn't universally loved ("the new trash can icon really ought to trash itself!" - OMG Ubuntu) so it's wise to discuss it and experiment with other designs. It's not empty criticism or cheap talk because the people in this thread are the people who actually make the current default theme that ships with Ubuntu.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 22, 2019

The other thing I wanted to try is a grey oblong with a lid, adding handles and grooves to make the Sesame Street-style "trash can" that's abstract enough for Suru.

@DanyGee

This comment has been minimized.

Copy link

DanyGee commented Feb 22, 2019

@ubuntujaggers @Feichtmeier
Thx for clarifying. Understood.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 23, 2019

(I'm trying to draw a non-blue or Sesame Street-style bin as well, but all efforts so far have been rubbish.)

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 23, 2019

IMO this is not terrible and is sort of Suru-shaped but I prefer the blue pedal bin:

image

I think if you gave this one to Oscar the Grouch he'd think he was meant to cook a casserole.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 24, 2019

Second attempt at a bin for Oscar:

image

Does anyone have any strong feelings about the blue pedal bin? I think it's the most conservative possible change that still looks like a bin, we'd just have to change the symbolic to match it.

@madsrh

This comment has been minimized.

Copy link
Member Author

madsrh commented Feb 24, 2019

It's a solid attempt @ubuntujaggers 😄 but perhaps a paperbasket works better than the Sesame Street-style bin

image

I'm not 100% sold but I'm +1 for exploring the pedal bin option. Have you got an idea for the symbolic icon?

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 24, 2019

image

image

??

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 24, 2019

Tbh I think we could make the symbolic mimetypes more like their full colour counterparts too...

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 25, 2019

Looking over the thread I think the best Oscar Grouch one is this:

image

Not sure why I didn't just copy it but I'll have a go next.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 25, 2019

Hey, this doesn't look awful at all! Nicked the gradient from the USB creator...

image

@madsrh @clobrano @Feichtmeier?

@rvz420

This comment has been minimized.

Copy link

rvz420 commented Feb 25, 2019

I really love the default blue trash. But I can't see the 3d effect you see... I always thought it was a "post mounted bin"

post mounted bin

But if it has to be changed the one with the pedal is also great, I don't know why but the blue has charm. 😄

@madsrh

This comment has been minimized.

Copy link
Member Author

madsrh commented Feb 25, 2019

@ubuntujaggers This doesn't look bad at all

I'm not sure if it's a good idea to add a highlight to the vertical lines, but you could do something like this:
image

image

@madsrh

This comment has been minimized.

Copy link
Member Author

madsrh commented Feb 25, 2019

Tbh I am happy to have the upstream Suru icon, the blue pedal bin, or the latest Oscar the Grouch bin (with or without extra highlights) in this context. So, I await the verdict

In that order or just happy with any of the suggestions? Did you deliberately leave out the paper basket?

...will the desktop trash icon vanish soon anyway...

Well, let's see what happens here. Gnome has these ideas that users don't need desktop icons, a system tray, a dock, a minimize button, dialog buttons outside the headerbar and so on, but Ubuntu has users that expect many of these "features". So sometimes, like with the desktop icons, Ubuntu devs are opting to maintain the desktop workflow Ubuntu users are used to.

Anyway, I don't want to make this call, but if the desktop trash icon is going away at some point, it would make sense for us to pick the trash metaphor that works best as symbolic icon.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Feb 25, 2019

In that order or just happy with any of the suggestions?

No strong order, but probably:

  • Upstream Suru icon (because I like the colour, don't mind the design, and it means I don't have to look at it every day and agonise over whether I did a good enough job 😄 )

  • Blue pedal bin

  • Oscar the Grouch

But honestly, no strong feelings between them and happy to go with consensus. I've currently got the Oscar the Grouch bin because I built it to do the screenshot.

I didn't leave out the waste paper basket deliberately, it just didn't occur to me... I haven't drawn one yet, and I or someone else would have to come up with a good-looking one. I have no objection to a waste paper basket :)

@real-amano

This comment has been minimized.

Copy link

real-amano commented Feb 28, 2019

Not in love with the pedal bin, nor with Sam's 3D one.

I think that "Oscar the grouch" is much more self descriptive and Suru/Yaru enough :)

Those are my favorite incarnations:https://user-images.githubusercontent.com/3986894/53323777-667f6c00-38df-11e9-8a33-b01fb1e6a508.png

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Feb 28, 2019

Prbly you are right! That one looks indeed very good

@real-amano

This comment has been minimized.

Copy link

real-amano commented Feb 28, 2019

We should think about empty and full states of the proposals as well. As that bin is closed, there is no chance to see its state.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 2, 2019

If the UI freeze is soon, do we want to do one of the new bins or leave it as-is for this release?

Also, is the full/empty distinction an important UI feature? Not saying don't do it, but maybe we could merge a new bin and then merge a two-design version when we have the second. If it's important to distinguish then that approach is no good however.

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Mar 2, 2019

I've always found annoying the icon of bin full 😀

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 2, 2019

I've always found annoying the icon of bin full grinning

Mine is never empty anyway, I only discovered this feature when I started drawing bins!

@madsrh

This comment has been minimized.

Copy link
Member Author

madsrh commented Mar 2, 2019

We could just add a bag in front of the bin like you did here: https://user-images.githubusercontent.com/38893390/53301276-a8a99e80-3848-11e9-9528-b0150c988ad7.png

EDIT: isn't this also how the symbolic icon works now?

@real-amano

This comment has been minimized.

Copy link

real-amano commented Mar 3, 2019

Not showing the full/empty state is like removing a feature.

@meetdilip

This comment has been minimized.

Copy link

meetdilip commented Mar 3, 2019

We could just add a bag in front of the bin like you did here: https://user-images.githubusercontent.com/38893390/53301276-a8a99e80-3848-11e9-9528-b0150c988ad7.png

EDIT: isn't this also how the symbolic icon works now?

With colours for full and empty

@madsrh

This comment has been minimized.

Copy link
Member Author

madsrh commented Mar 3, 2019

With colours for full and empty

While it's good to have an indicator of the state, IMO these colors doesn't fit very well the style of the Suru icons.

EDIT: Also there's only two states (as I understand it) here: Empty and Full. IMHO it doesn't make sense that if you delete a 5kb file on a fresh install the trashcan turns red, signaling danger/warning/take-action!

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 4, 2019

image

??

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 4, 2019

Not showing the full/empty state is like removing a feature.

100% - just wondered if it was an important feature or could be "gapped".

@madsrh

This comment has been minimized.

Copy link
Member Author

madsrh commented Mar 5, 2019

@ubuntujaggers doesn't the bag look a bit too round? 💰

Perhaps something like:
image

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 5, 2019

That's a great bag, where's it from? Do you have just the bag on a clear or pale background...? :)

@madsrh

This comment has been minimized.

Copy link
Member Author

madsrh commented Mar 5, 2019

Do you have just the bag on a clear or pale background...? :)

https://www.vectorstock.com/royalty-free-vector/garbage-bag-icon-flat-style-vector-13520922

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 5, 2019

Tried this in the meantime:

image

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 5, 2019

I don't think it's awful but it doesn't feel very Yaru yet...

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Mar 5, 2019

What if we only change the colour of the current master icon for now? I think Didier also said that the bright blue is very distracting. Everything else then next cycle

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 5, 2019

Yeah, maybe invert it (blue logo on light grey)?

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 6, 2019

image

??

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 6, 2019

@madsrh

image

??

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 6, 2019

I'm really struggling to make a legible version of the recycling logo at 16px. It's got a lot of non-right angle lines and the arrow heads are quite fiddly, so there's a lot of anti-aliasing and it isn't clear what it is by itself. It doesn't matter so much on the full colour graphic but is really suboptimal for a symbolic.

The best symbolic I've come up with so far is just a tiny bin of the same shape (the paper doesn't peep out when it's empty):

image

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Mar 6, 2019

Tbh this looks pretty good

@madsrh

This comment has been minimized.

Copy link
Member Author

madsrh commented Mar 6, 2019

Hmm, I'm in doubt here. It could work, but it isn't very obvious. Try hiding the label and ask a friend what the icons are for - I'm sure they will get music, pictures and videos right.
Don't get me wrong, you did a great job here @ubuntujaggers (again). The icon looks good, but I doubt people will know what it is until they click it.

This is NOT a -1 just a zero 😆

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

ubuntujaggers commented Mar 6, 2019

Try hiding the label and ask a friend what the icons are for

Tbh I think the recycling logo (if we could make it work at 16px) would be even worse in that regard. As a standalone glyph in a computing context you'd guess "refresh" or "sync" or something. At least the one above looks like a bit like a tub that you might put stuff in. Hard to imagine a more intuitive symbol than Oscar the Grouch...

@madsrh

This comment has been minimized.

Copy link
Member Author

madsrh commented Mar 6, 2019

Hard to imagine a more intuitive symbol than Oscar the Grouch.

I completely agree

@madsrh

This comment has been minimized.

Copy link
Member Author

madsrh commented Mar 7, 2019

Closed by #1237 🎉

@madsrh madsrh closed this Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.