Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring current non-uniform icon set into Yaru #1209

Merged
merged 2 commits into from Feb 25, 2019

Conversation

Projects
None yet
5 participants
@ubuntujaggers
Copy link
Contributor

ubuntujaggers commented Feb 24, 2019

Okay - this should be the same icon set but without any extra symlinks and without conflicts.

Unfortunately it wasn't as easy as I hoped with the symlinks, it didn't "just work". But I ran the symlink script one-by-one and believe I've only committed relevant symlinks. Even so it's a massive lot of commits, over a thousand, because you have ten versions of every new icon and then lots of symlinks for each changed icon.

Suggest we test this one (is it possible to roll back?) due to the sheer number of commits!!

image

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Feb 24, 2019

Also: after I pushed, I deleted all my local Yaru-related folders (including usr/share/icons) and then cloned what I'd pushed to my own laptop and re-built it from there. So I know it works (it's not like I'm sitting here with a version that works but might have unpushed changes or something).

@didrocks

This comment has been minimized.

Copy link
Member

didrocks commented Feb 24, 2019

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr1209.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr1209 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Feb 24, 2019

I think you missed disk usage analyzer =)

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Feb 24, 2019

I'm onto it!

@didrocks

This comment has been minimized.

Copy link
Member

didrocks commented Feb 24, 2019

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr1209.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr1209 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Feb 24, 2019

Missing symlink - seems to have fixed it.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Feb 25, 2019

@ubuntujaggers package-app and ubiquity have still the old baseplate :D Could you tackle that? 👼

Edit: and apport, photos-app, messaging-app and notes-app + symlinks :D
But we could do that in a second PR and merge this one - if you agree @clobrano @madsrh @ubuntujaggers , since @8none1 thumbs upped the testing PR (btw, should we close the testing PR?)

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Feb 25, 2019

Oops, sorry for missed icons. But yes, I'd be happy to merge this branch if it works (rather than poking it any more!) and then just improve icons and add the few missing ones with normal non-enormous PRs if everyone's happy?

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Feb 25, 2019

Okay i'll merge this one, Update the issue with the missing icons and close the other pr.

Thank you very much for this incredible one man work jaggers!!!

@Feichtmeier Feichtmeier merged commit 5563eb2 into master Feb 25, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Feb 25, 2019

Thank you very much for this incredible one man work jaggers!!!

No problem at all, I'm very glad we finally found a way forward with icons in Yaru :)

  • Do we want to update the screenshots on the main page of the Github? I've got to say, when I look at the current screenshots with all the squircles, I think your squircle-free idea was definitely the right one in the end - it just looks a bit better and more polished IMO on my desktop.

  • Dare we tip OMG Ubuntu off? I think the last the wider community heard was that we were sticking squircles on absolutely everything...

@madsrh

This comment has been minimized.

Copy link
Member

madsrh commented Feb 25, 2019

No problem at all, I'm very glad we finally found a way forward with icons in Yaru :)

🎉 +1

Dare we tip OMG Ubuntu off? I think the last the wider community heard was that we were sticking squircles on absolutely everything...

Ha ha, good point 😄 They will know on April 18th 😉
I'm sorry to bring this up again, but the first question we will be asked is about 3rd party apps and non core Gnome apps. I shared my thoughts here, but are we 100% on the same page here? I think that we need to be and include this in the OMG tip.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Feb 25, 2019

I'm sorry to bring this up again, but the first question we will be asked is about 3rd party apps and non core Gnome apps. I shared my thoughts here, but are we 100% on the same page here? I think that we need to be and include this in the OMG tip.

From my point of view, the good thing about the non-uniform icon set is we can mix and match. We have the freedom to make our own Suru-ish icons for third party apps if a) upstream are happy, b) we want to, and c) I or someone else is able to draw something which looks better than the normal icon in the context of Yaru (which won't be always). But if any of those criteria isn't met, we can just use the upstream icon like everyone else and it won't matter. When all the criteria are met - as in, we've got a green light, we want it, and we've actually got a good-looking icon - I don't think there's anything stopping us?

So in terms of our stated policy on icons we could just leave the door open without committing to particular apps at this stage, other than Shotwell which already ticks the boxes?

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Feb 26, 2019

I agree, point A is the most important. I don't know how we can make this clearer for upstream and maintainers, but it would be the best if the idea comes from them first

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Feb 26, 2019

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Feb 26, 2019

Yeah, it didn't take long 😄

@ubuntujaggers ubuntujaggers deleted the NewIconTheme_transitionbranch branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.