Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding icons and symlinks for full colour tick and cross actions #1689

Merged
merged 2 commits into from Jan 15, 2020

Conversation

ubuntujaggers
Copy link
Contributor

As @madsrh notes, we will likely be changing the icon itself to match new colours, but this PR has all the symlinks etc. for testing. If it works in Ubiquity we can consider whether to include the symlinking of the dropbox emblems in this PR too. Fixes #1686 .

@Feichtmeier
Copy link
Member

Awesome Stuart!
This will be a bit tricky to test since the page with the entries comes after you partitioned some drive :D
I'll try with an usb stick

@Feichtmeier
Copy link
Member

Should we eventually exchange the icons with these two?
#1686 (comment)

@madsrh @ubuntujaggers

@ubuntujaggers
Copy link
Contributor Author

Should we eventually exchange the icons with these two?
#1686 (comment)

@madsrh @ubuntujaggers

Done and pushed.

I've not touched the corresponding folder emblems yet - I think that's a different PR where we look at all the emblems (for instance: recolour all of them and make the glyphs less hairline to match these two?).

@Feichtmeier
Copy link
Member

@ubuntujaggers thanks! I don't find a way to test this except creating a new VM since those fields only come after you partioned your disk (in the installer)
Maybe you could double check if you did everything correctly from your perfection and then merge it?
This can not really break anything and we are in the dev cycle so enough time to fix

@ubuntujaggers ubuntujaggers marked this pull request as ready for review January 15, 2020 17:03
@ubuntujaggers ubuntujaggers merged commit 208ad80 into master Jan 15, 2020
@ubuntujaggers ubuntujaggers deleted the IconTheme_TickAndCross branch February 12, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing icons: checkmark and close-X action icons
2 participants