Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubiquity icon based on Circle of Friends forming from pixels #1770

Merged
merged 2 commits into from Jan 22, 2020

Conversation

@ubuntujaggers
Copy link
Contributor

ubuntujaggers commented Jan 21, 2020

image

Made this PR so someone who knows how to test Ubiquity, can do :)

I think the other sizes need more work.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 21, 2020

Thanks!!!
I think it looks very good
I'll test it tomorrow

@madsrh

This comment has been minimized.

Copy link
Member

madsrh commented Jan 22, 2020

Nice work ubuntujaggers 👍 but are you really reinstalling Ubuntu so often that you've put Ubiquity in the dock 😂😜

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 22, 2020

@madsrh

When you want to install Ubuntu you either choose "install Ubuntu" (!!! In which case you don't see either the icon, a desktop or the dock at all !!!) and sooooome people choose "try Ubuntu"... For those people there is that shortcut on the dock which starts the installer again after they tried Ubuntu enough. When they click the icon the installer launches again. This time as an app on top of a regular gnome session so it gets placed on the dock like all apps you start :)

(If you know this and I just didn't get the joke sorry for this wall of text)

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 22, 2020

Screenshot from 2020-01-22 09-51-01

I think it looks perfect 👍 Good job!

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 22, 2020

I've pushed an improved version at the different sizes:

image

Caveat: it looks crap on a white background because the edging around the pixels is so busy:

image

Will this icon ever be shown on a light background? If so I think we need to rework.

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 22, 2020

Let me see if I can make it "cleaner"...

@madsrh

This comment has been minimized.

Copy link
Member

madsrh commented Jan 22, 2020

@Feichtmeier Are they (still) blue? BTW Yes, that icon looks great!

image

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 22, 2020

Yes we need to fix this

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 22, 2020

I don't think I can make it cleaner without rethinking, it's an effect of the "backplate" having tiny pieces.

If it's only seen on the launcher and wallpaper, it doesn't matter. It will only affect people who change the wallpaper in the live trial.

But if this icon shows up in a dialogue box or something it won't be great.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Jan 22, 2020

I don't think I can make it cleaner without rethinking, it's an effect of the "backplate" having tiny pieces.

If it's only seen on the launcher and wallpaper, it doesn't matter. It will only affect people who change the wallpaper in the live trial.

But if this icon shows up in a dialogue box or something it won't be great.

I don't think anyone will change the wallpaper in the live session to be white :)
Imho this is looking very nice.

@Feichtmeier Feichtmeier merged commit 4fd75d3 into master Jan 22, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ubuntujaggers

This comment has been minimized.

Copy link
Contributor Author

ubuntujaggers commented Jan 22, 2020

So it should look like this on the live disk desktop (mockup):

image

Pretty smart I think 👍

@madsrh madsrh mentioned this pull request Jan 23, 2020
@ubuntujaggers ubuntujaggers deleted the BetterUbiquity branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.