New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge all repositories into a single one #628

Merged
merged 682 commits into from Jul 18, 2018

Conversation

Projects
None yet
7 participants
@didrocks
Member

didrocks commented Jul 17, 2018

This is the merge of all communitheme related repositories and moved into subdirectory.

In addition, it fixes some issues in the build system (duplicated icons, wrongly assigned names) and ensure that we can change via a single "project_name" the whole directories and theme outputs.
A single source package is available creating the different binary packages (renamed as well).
The CI system is kept as well, and reshaped building the gtk-common-themes snap.
For backward compatibility, symlinks and other renaming are done in the snap itself, which will still keep the name "communitheme".

Feichtmeier and others added some commits May 7, 2018

Completely opaque top panel on maximized windows
Transparent top panel on maximized windows might cause some misundersanding
for the user. See #173
Merge pull request #176 from ubuntu/popovers
popover_color_adjust
Merge pull request #178 from ubuntu/light-dialog-windows
Light dialog windows & green login buttin
Merge pull request #177 from ubuntu/issue173
Completely opaque top panel on maximized windows
Merge pull request #185 from ubuntu/light-dialog-windows
message_dialog_dark_text_normal_weight

didrocks and others added some commits Jul 16, 2018

Ship a session and mod files when doing upstream build
This ease trying the new version without having to modify files
manually.
Factor out all session related work to sessions/ directory, including
gsettings overrides files.
Merge pull request #243 from ubuntu/activities_button
Remove the ubuntu logo in activities, add the new grid icon again
Prepare project name renaming in snap
As we'll switch back to the previous name in the snap.
New debian packaging
One debian source package with multiple binary packages, replacing all
others debian sources.
Add backward compatible icon name for snap
We expect the name "Suru", add a symlink to it.
@didrocks

This comment has been minimized.

Member

didrocks commented Jul 17, 2018

A new test snap version is available using: snap refresh communitheme --channel=edge/gtk-communitheme-pr628.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/gtk-communitheme-pr628 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@Feichtmeier

This comment has been minimized.

Contributor

Feichtmeier commented Jul 17, 2018

Is the Communitheme Icon & Cursor option selected by default after installing and rebooting into the sesssion? This VM already had the snap so I needed to select the Communitheme Icon & Cursor option manually now after updating. The Suru cursor and Icon name could also be removed as an option since it is a bit confusing for new users in my opinion :)

Other than that, everything works with this PR! Great job - thank you!

@didrocks

This comment has been minimized.

Member

didrocks commented Jul 17, 2018

Hum, if the VM is vanilla, nothing should need be selected again. This was after an update and a reboot? Can you try to reproduce the issue and details the exact step on a clean VM for me to reproduce?

@Feichtmeier

This comment has been minimized.

Contributor

Feichtmeier commented Jul 17, 2018

Alright - making a new vm now.

One more thing, could you set the default font size to 11 again, because of the issue cutting the window thumbnail description labels? It has been reported upstream and they are working on it (its "Only" if you select any other font than cantarell xD)

@didrocks

This comment has been minimized.

Member

didrocks commented Jul 17, 2018

This is quite complex to qualify as a SRU, but we can try. Do you mind opening a bug against ubuntu-settings package in launchpad, following https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template?

I think the rationale and screenshot before/after, telling it's only affecting people using the communitheme snap is fine.

@Feichtmeier

This comment has been minimized.

Contributor

Feichtmeier commented Jul 17, 2018

Can you try to reproduce the issue and details the exact step on a clean VM for me to reproduce?

Fresh install +
sudo snap install communitheme --channel=edge/gtk-communitheme-pr628
reboot
sudo apt install gnome-tweaks

  1. Communitheme cursor + suru icons are selected (maybe we should remove the "suru" entry?)
    screenshot from 2018-07-17 15-24-59
  2. The font size issue (already reported on gnome gitlab):
    vanilla install/session:
    screenshot from 2018-07-17 15-18-37
    After communitheme install/reboot:
    screenshot from 2018-07-17 15-23-06
    screenshot from 2018-07-17 15-25-08

So maybe you misunderstood me. You once changed this to 10 for aestitic reasons requested by @madsrh - but the issue still persists so I'd suggest to change it back to 11 (like vanilla session) to prevent this cut-off labels. Or maybe I misunderstood you and you know this all and yet I should report it on launchpad? =D

@didrocks

This comment has been minimized.

Member

didrocks commented Jul 17, 2018

  1. It sounds all good, even if it's set to Suru, it's our fork which is set. We can't change those names, and correct selection is applied, in a backward compatible way on purpose. So, in a nutshell, all looks good to me :)
  2. Yes, but as said when I made the package and integration for bionic, the tradeoff is that those settings are in a package in ubuntu, not in the snap. This is a change which thus need to go through the SRU process, hence asking for the bug and filing up the paperwork so that I can do that change.
@Feichtmeier

This comment has been minimized.

Contributor

Feichtmeier commented Jul 17, 2018

@didrocks

This comment has been minimized.

Member

didrocks commented Jul 18, 2018

Got good feedback on the hub and here! Time to push the BGB, Big Green Button ;)

@didrocks didrocks merged commit 9f9c76a into master Jul 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@didrocks didrocks deleted the parameterized_theme_name branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment