Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell/dock: Fixed dock transparency #904

Merged
merged 2 commits into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@clobrano
Copy link
Member

commented Oct 8, 2018

New dash-to-dock version in Cosmic introduced some changes for which
panel and dock transparency are not aligned anymore.

Fixing this increasing the dock's transparency from 0.6 to 0.8

Closes #890

shell/dock: Fixed dock transparency
New dash-to-dock version in Cosmic introduced some changes for which
panel and dock transparency are not aligned anymore.

Fixing this increasing the dock's transparency from 0.6 to 0.8

Closes #890
@didrocks

This comment has been minimized.

Copy link
Member

commented Oct 8, 2018

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr904.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr904 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@didrocks

This comment has been minimized.

Copy link
Member

commented Oct 9, 2018

$dash-alpha-value won't impact cosmic?

Note that there is some noise in the diff (trailing whitespaces being removed in unrelated lines), mind cleaning that up?

@clobrano

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2018

$dash-alpha-value won't impact cosmic?

the change is only for cosmic, since bionic does not ship the same dock version. Was that the question?

Note that there is some noise in the diff (trailing whitespaces being removed in unrelated lines), mind cleaning that up?

my editor automatically cleaned up some whitespaces. I'll fix it

@clobrano clobrano changed the title [COSMIC ONLY] shell/dock: Fixed dock transparency shell/dock: Fixed dock transparency Oct 9, 2018

@didrocks

This comment has been minimized.

Copy link
Member

commented Oct 9, 2018

As discussed on IRC, this will land in both bionic (snap) and cosmic, which is OK.

@clobrano

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2018

Since Bionic will use master branch in any case, we'll ship this change to both versions.

@didrocks didrocks merged commit 6630744 into master Oct 9, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@didrocks didrocks deleted the issue890/dock-transparency-fix branch Oct 9, 2018

@ubuntujaggers

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2018

Hmm, I've tried the PR channel above, edge and stable and it still looks ever-so-slightly different now.

@clobrano

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2018

In bionic is expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.