New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix nautilus 3.30+ pathbar styling #982

Merged
merged 6 commits into from Nov 24, 2018

Conversation

Projects
None yet
4 participants
@Feichtmeier
Copy link
Contributor

Feichtmeier commented Nov 22, 2018

"Work in progress"- and "eventually closed"-PR. Mostly to test this design on nautilus 3.26 on our hosts

Removes the background and the border-radius to avoid a stretched underline

image

peek 2018-11-22 22-48

This way we could keep the orange underline in this widget.
Opinions @madsrh @clobrano @godlyranchdressing ?

Edit: scroll down to see latest results

Closes #914

@madsrh

This comment has been minimized.

Copy link
Member

madsrh commented Nov 22, 2018

I like it 👍 but we do agree the the orange line is only there for consistency, right? It seem like using both the line and bold font (and changing the color to white) is a bit unnecessary.

@didrocks

This comment has been minimized.

Copy link
Member

didrocks commented Nov 22, 2018

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr982.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr982 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Nov 22, 2018

Nope
image

Needs work : S Would have been too nice ^.^

@madsrh I don't know. To avoid the "problem" I see which I posted on the hub about. I think this way we could avoid it a bit. But it's still a bit of a mess in the headerbar

Edit: works now
image
🎉

@didrocks

This comment has been minimized.

Copy link
Member

didrocks commented Nov 22, 2018

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr982.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr982 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Nov 23, 2018

If we would merge this one into master, I could fix this #983 for both nautilus versions I think

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Nov 23, 2018

Is the orange underline still necessary? It looks too much in 3.30

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Nov 23, 2018

No I think not - was just to cut down the "widget problem" I saw - also I was wrong about needing to merge this into master brain fart
Too much coffee!

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Nov 23, 2018

peek 2018-11-23 12-21

So you would both prefer no orange underline, since the fat label is hardcoded?

@didrocks

This comment has been minimized.

Copy link
Member

didrocks commented Nov 23, 2018

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr982.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr982 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

1 similar comment
@didrocks

This comment has been minimized.

Copy link
Member

didrocks commented Nov 23, 2018

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr982.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr982 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Nov 23, 2018

Hmmmmm I think we have a winner... works the same on 3.26 and 3.30 and looks quiet sexy + upstream
peek 2018-11-23 12-47
@madsrh @clobrano

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Nov 23, 2018

@madsrh @clobrano shall I merge this?

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Nov 23, 2018

Let me have a look on the real thing, even if it looks good already

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Nov 23, 2018

Okay I leave both PRs up to your merge then :) I hope the coffee is soon out of my blood

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Nov 23, 2018

What do you think about having only the underline effect on hover? It seems strange to me to see the label getting brighter and the underline below with a different color.

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Nov 23, 2018

I am not "set" on this question :) Let @madsrh decide

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Nov 24, 2018

@clobrano like this?
peek 2018-11-24 15-13

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Nov 24, 2018

@clobrano like this?
peek 2018-11-24 15-13

Yes!

@Feichtmeier

This comment has been minimized.

Copy link
Contributor

Feichtmeier commented Nov 24, 2018

Could you resolve the conflict? I fear I could produce a failure

@clobrano

This comment has been minimized.

Copy link
Member

clobrano commented Nov 24, 2018

having a look now

@clobrano clobrano merged commit 1015ec3 into master Nov 24, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@didrocks

This comment has been minimized.

Copy link
Member

didrocks commented Nov 24, 2018

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr982.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr982 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment