Feat/guppy explorer#505
Conversation
| "guppyConfig": { | ||
| "dataType": "subject", | ||
| "fieldMapping": [ | ||
| { "field": "project", "name": "Project" }, |
There was a problem hiding this comment.
Should we automate this part to only configure the special mapping?
I mean if it is only project -> Project or vital_status -> Vital Status you don't need to put it in the fieldMapping.
There was a problem hiding this comment.
I think sometimes some field name mapping will need more caring, like thrpyv, but yeah automation is a good idea, I think we could combine both automation and customized names
e27040d to
0dae0fa
Compare
| "login": { | ||
| "title": "NIAID Data Hub", | ||
| "subTitle": "Explore, Analyze, and Share Data", | ||
| "subTitle": "search, compare, and download data", |
There was a problem hiding this comment.
can you change this back to "Explore, Analyze, and Share Data" ?
There was a problem hiding this comment.
Prod use this so I copied them
There was a problem hiding this comment.
:O I'll change prod - they should all be "Explore, Analyze, and Share Data" now
| }, | ||
| "table": { | ||
| "enabled": false | ||
| "enabled": true, |
| const end = (this.state.currentPage + 1) * this.state.pageSize; | ||
| return ( | ||
| <div className={`explorer-table ${this.props.className}`}> | ||
| <p className='explorer-table__description'>{`Showing ${start} - ${end} of ${totalCount} cases`}</p> |
There was a problem hiding this comment.
"cases" here shouldn't be hardcoded - for example, NIAID uses "subjects"
* feat(Explorer): export to PFB * feat(Guppy/Explorer): unified toaster for export to workspace and export to PFB * feat(Guppy/Explorer): functionality for export to PFB button
Use guppy for data explorer instead of arranger. Portal config like this (under
dataExplorerConfigblock):Notice that
filtersandchartsare same as previous cofnig, and fortablethere's extratable.fieldsblock. For backward compatibility, if there's no "guppyConfig" block in portal config, data explorer will still use arranger for data explorer page by readingarrangerConfigand related config blocks.New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes