New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/guppy explorer #505
Feat/guppy explorer #505
Conversation
data/config/default.json
Outdated
"guppyConfig": { | ||
"dataType": "subject", | ||
"fieldMapping": [ | ||
{ "field": "project", "name": "Project" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we automate this part to only configure the special mapping?
I mean if it is only project -> Project
or vital_status -> Vital Status
you don't need to put it in the fieldMapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think sometimes some field name mapping will need more caring, like thrpyv
, but yeah automation is a good idea, I think we could combine both automation and customized names
data/config/ndh.json
Outdated
@@ -123,7 +123,7 @@ | |||
}, | |||
"login": { | |||
"title": "NIAID Data Hub", | |||
"subTitle": "Explore, Analyze, and Share Data", | |||
"subTitle": "search, compare, and download data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this back to "Explore, Analyze, and Share Data" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prod use this so I copied them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:O I'll change prod - they should all be "Explore, Analyze, and Share Data" now
data/config/ndh.json
Outdated
"hiv_status" | ||
] | ||
} | ||
] | ||
}, | ||
"table": { | ||
"enabled": false | ||
"enabled": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this to false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure~
const end = (this.state.currentPage + 1) * this.state.pageSize; | ||
return ( | ||
<div className={`explorer-table ${this.props.className}`}> | ||
<p className='explorer-table__description'>{`Showing ${start} - ${end} of ${totalCount} cases`}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"cases" here shouldn't be hardcoded - for example, NIAID uses "subjects"
* feat(Explorer): export to PFB * feat(Guppy/Explorer): unified toaster for export to workspace and export to PFB * feat(Guppy/Explorer): functionality for export to PFB button
Use guppy for data explorer instead of arranger. Portal config like this (under
dataExplorerConfig
block):Notice that
filters
andcharts
are same as previous cofnig, and fortable
there's extratable.fields
block. For backward compatibility, if there's no "guppyConfig" block in portal config, data explorer will still use arranger for data explorer page by readingarrangerConfig
and related config blocks.New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes