-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PXP-4872 Fix usersync access revoke #743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 8248
💛 - Coveralls |
This pull request fixes 15 alerts when merging 250fda8 into f5a712b - view on LGTM.com fixed alerts:
|
paulineribeyre
force-pushed
the
fix/group-sync
branch
from
December 12, 2019 23:51
250fda8
to
ba3d5eb
Compare
paulineribeyre
requested review from
vpsx,
Avantol13 and
itsJiaqi
and removed request for
vpsx
December 13, 2019 00:13
vpsx
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Digging the telemetry -> dbGaP authorization changes in docs :P
- Gotta update the gen3authz loose pin in setup.py also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses the following:
/A
and we renamed/A/B
to/A/C
) -> can only be reproduced by renaming top-level resources, because the "PUT resource" does its job of overriding all the subresources. So users could not still have access to it (the validation check makes sure the resource paths users have access to exist). We can still delete all obsolete resources in the future to clean up the DB but i didn't do it hererelates to uc-cdis/gen3authz#26
Bug Fixes
Improvements
Dependency updates