(PXP-6042): add encoded spaces #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
paulineribeyre
previously approved these changes
May 14, 2020
Comment on lines
374
to
377
| if sorted([url.replace("%20", " ") for url in urls]) != sorted( | ||
| actual_record["urls"] | ||
| ): | ||
| output = f"{guid}|urls|expected {urls}|actual {actual_record['urls']}\n" |
Contributor
There was a problem hiding this comment.
this is nitpicky but i think you should pull the .replace out of the if, so that it's easier to read and you can display the replace 'd urls in the output
added 2 commits
May 15, 2020 10:30
… into fix/encode_spaces
paulineribeyre
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description about what this pull request does.
Please make sure to follow the DEV guidelines before asking for review.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes