Labels restructuring #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide an optional argument named label to set the _invoker_label attribute. This value is the base label name that is checked for finvoker options on services.
Pre-compile service label key patterns for parsing our invoker types and arguments. These are intended to match the new form finvoker.<type> for invoker types and finvoker.<type>.<args> for arguments.
The label value was accidentally shortened to finvoke in 9121bd9.
Filter for services that have any finvoker.<type> label, instead of specifically an finvoker label. Services may have more than one invoker type.
Under the new form label patterns, services may have more than one activate invoker type defined. Parse out all the types when notifying for a service.
Extract the arguments for specific invoker types by matching on labels with the key pattern finvoker.<type>.<arg>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support invoker labels of the form finvoker. and finvoker... Multiple types of invokers may be specified on a service simultaneously. However, multiple instances of the same type of invoker is not supported by this syntax.