Migrate hashing from blake2b to blake3. #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW: at the spec level, there's nothing preventing you from using BLAKE3. There is a question about canonicalization for revocation, but the links inside the UCAN itself are agnostic to which hash they use as long as they're resolvable (Also IMO BLAKE3 is awesome, and we're starting to see it show up a buch in the ecosystem) |
|
More specifically, rs-ucan worked flawlessly when trying out blake3 other than |
|
@jsantell would you be willing to clean up the lint checks? |
Updated! Edit: one lint failed on nightly, repushing |
jsantell
force-pushed
the
blake3
branch
2 times, most recently
from
7780472
to
e51dfb2
Compare
|
A rebase will likely make this change pass muster :) |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're considering using blake3 for our hashing in noosphere using it with Ucan. Changing the hashing would be a breaking change, not matching previous encodings. Similarly, we could make the hashing generic. What do you all think?