chore: Remove stdweb feature from instant crate to circumvent downstream issues with stdweb/wasm-bindgen

[jsantell]

Observed in https://github.com/ucan-wg/rs-ucan/actions/runs/5026570677/jobs/9015624781, there's an issue using wasm-bindgen > 0.2.84; this lets us build for wasm32 targets again

[bgins]

Hey @jsantell 👋

I'm working on adding JS packaging support on a local branch, and I also ran into this issue. I was able to resolve it by dropping the stdweb feature from the instant dependency:

rs-ucan/ucan/Cargo.toml

Line 30 in f75b00a

instant = { version = "0.1", features = ["wasm-bindgen", "stdweb"] }

According to the instant docs, it is only necessary to use either the wasm-bindgen or stdweb feature: https://github.com/sebcrozet/instant#instant. What would you think about dropping stdweb instead of pinning wasm-bindgen? It seems that stdweb is unmaintained, so there might never be a fix for it.

[cdata]

Yeah 👍 to @bgins let's try dropping stdweb!

[jsantell]

Hey @jsantell wave

I'm working on adding JS packaging support on a local branch, and I also ran into this issue. I was able to resolve it by dropping the stdweb feature from the instant dependency:

rs-ucan/ucan/Cargo.toml

Line 30 in f75b00a

instant = { version = "0.1", features = ["wasm-bindgen", "stdweb"] }

According to the instant docs, it is only necessary to use either the wasm-bindgen or stdweb feature: https://github.com/sebcrozet/instant#instant. What would you think about dropping stdweb instead of pinning wasm-bindgen? It seems that stdweb is unmaintained, so there might never be a fix for it.

SGTM! Updated PR with your suggestion

[bgins]

Looks good to me! 🎉

[codecov-commenter]

Codecov Report

Merging #86 (3ed84bd) into main (f75b00a) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   57.47%   57.52%   +0.05%     
==========================================
  Files          23       23              
  Lines         776      777       +1     
  Branches      187      187              
==========================================
+ Hits          446      447       +1     
  Misses        202      202              
  Partials      128      128              

see 1 file with indirect coverage changes

[cdata]

Looks like one lint to fix for nightly's sake @jsantell others looks great

[jsantell]

Updated fixing the nightly lint on RawCodec::default()

[cdata]

Woot!