Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow fct and prf to be nullable. Fixes #98 #99

Merged
merged 1 commit into from May 25, 2023

Conversation

jsantell
Copy link
Contributor

Description

Allows fct and prf to be nullable when consuming, and adhering to canonicalization, will not encode empty values in the resulting JWT.

Link to issue

#98

Type of change

This makes rs-ucan adhere to the spec as of 0.9.0 w/r/t prf and fct fields which MAY be undefined. This is a breaking change w/r/t some interfaces, but notably also the canonicalization.

Test plan (required)

Updated existing tests

@jsantell jsantell requested review from cdata and a team as code owners May 25, 2023 20:08
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #99 (2267bec) into main (c0bec08) will increase coverage by 0.06%.
The diff coverage is 66.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   57.36%   57.43%   +0.06%     
==========================================
  Files          23       23              
  Lines         774      787      +13     
  Branches      187      191       +4     
==========================================
+ Hits          444      452       +8     
- Misses        202      204       +2     
- Partials      128      131       +3     
Impacted Files Coverage Δ
ucan/src/chain.rs 63.80% <57.14%> (+0.34%) ⬆️
ucan/src/ipld/ucan.rs 71.11% <60.00%> (-3.25%) ⬇️
ucan/src/builder.rs 78.57% <75.00%> (-0.78%) ⬇️
ucan/src/ucan.rs 69.47% <100.00%> (ø)

Copy link
Member

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@cdata cdata merged commit 6802b5c into ucan-wg:main May 25, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request May 25, 2023
@jsantell jsantell deleted the issue-98 branch June 6, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants