Stage Phase Rocket Chip Bump #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
zhemao
requested changes
Apr 15, 2020
src/main/scala/TraceIO.scala
Outdated
| @@ -83,7 +87,7 @@ object TraceOutputTop { | |||
| new TraceOutputTop(proto.map(t => TracedInstructionWidths(t.head)), proto.map(_.size)) | |||
| } | |||
|
|
|||
| trait CanHaveTraceIO { this: HasTiles => | |||
| trait CanHaveTraceIO { outer: HasTiles => | |||
There was a problem hiding this comment.
Wait, why is it outer instead of this now? You don't make this change for any of the other traits.
There was a problem hiding this comment.
Yeah this doesn't change anything it's just providing an alias for the self type. I'll put it back.
I don't remember why i changed this, but i think i started rearchitecting this class but then stopped myself half-way without completely reverting all the changes.
jwright6323
reviewed
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ucb-bar/chipyard#503.