Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container Manager Wait Until Ready #417

Merged
merged 10 commits into from Mar 8, 2018
Merged

Container Manager Wait Until Ready #417

merged 10 commits into from Mar 8, 2018

Conversation

chester-leung
Copy link
Member

The changes force the DockerContainerManager and the KubernetesContainerManager to sleep until the container/deployment is ready.

@chester-leung chester-leung reopened this Feb 24, 2018
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1048/
Test FAILed.

dcrankshaw
dcrankshaw requested changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why that test is failing, but other than that this looks good. Just some minor comments.

.gitignore Outdated
@@ -18,4 +18,6 @@ _build/
dependency-reduced-pom.xml
*.iml

k8s_starter.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this was removed?

clipper_admin/clipper_admin/docker/docker_container_manager.py Outdated
for _ in range(num_missing):
self._add_replica(name, version, input_type, image)
name = self._add_replica(name, version, input_type, image)
model_container_names += [name]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to model_container_names.append(name). The way you're doing it right now constructs a new list in each iteration.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1061/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1065/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1066/
Test PASSed.

dcrankshaw
dcrankshaw requested changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go once you remove the changes to .gitignore

.gitignore Outdated
@@ -18,4 +18,6 @@ _build/
dependency-reduced-pom.xml
*.iml

k8s_starter.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this was removed?

.gitignore Outdated
@@ -18,4 +18,6 @@ _build/
dependency-reduced-pom.xml
*.iml

k8s_starter.py
integration-tests/replica_test.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Must have forgotten to save. Sorry about that.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1077/
Test PASSed.

dcrankshaw
dcrankshaw approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1078/
Test PASSed.

@dcrankshaw dcrankshaw merged commit 42abb25 into ucbrise:develop Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcrankshaw dcrankshaw dcrankshaw approved these changes

Assignees
No one assigned
Labels
status: accepted type: stability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chester-leung @AmplabJenkins @dcrankshaw