Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Word Filter interactive #1020

Closed
eAlasdair opened this issue Jun 24, 2019 · 2 comments
Closed

Improve Word Filter interactive #1020

eAlasdair opened this issue Jun 24, 2019 · 2 comments
Assignees

Comments

@eAlasdair
Copy link
Collaborator

@eAlasdair eAlasdair commented Jun 24, 2019

  • The file should be loaded asynchronously, so that it doesn't lock up the webpage
  • The word list should be under the interactive, so that it fits more neatly
  • Consider making it a whole-page interactive only if it still doesn't fit neatly
@courtneycb courtneycb self-assigned this Jul 15, 2019
@courtneycb
Copy link
Contributor

@courtneycb courtneycb commented Jul 21, 2019

The file is loaded asynchronously but the file contains roughly 250,000 words that are loaded into an array which is then iterated over. The browser freezes while the for loop is running over the array.

Loading

@eAlasdair eAlasdair assigned eAlasdair and unassigned courtneycb Jul 30, 2019
@eAlasdair
Copy link
Collaborator Author

@eAlasdair eAlasdair commented Jul 31, 2019

The for loop is pretty much instantaneous, the (largely unavoidable) slowdown is when it goes to print all the words it matched. Best solution is to limit the number of words loaded at a time

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants