Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section separator should only show after sections, not before #1065

Closed
courtneycb opened this issue Jul 1, 2019 · 2 comments

Comments

@courtneycb
Copy link
Contributor

commented Jul 1, 2019

Personally I think the first separator shouldn't be there because there is no section before that one on the page. Feel free to close this if you think it should be this way.

image

@courtneycb courtneycb added the frontend label Jul 1, 2019

@eAlasdair

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

This also highlights the inconsistency we have - some chapter sections start with text (no heading), some start with headings

@eAlasdair eAlasdair added the suggestion label Jul 1, 2019

@JackMorganNZ

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Agreed, two points:

  • As @timbellnz a few weeks ago, it's best to not having two headings against each other. We could easily add a sentence here to solve this.
  • Removing the first one should be possible via CSS rules.

@eAlasdair eAlasdair self-assigned this Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.