Reorganise box images for interactives #393

Closed
JackMorganNZ opened this Issue Oct 12, 2016 · 2 comments

Projects

None yet

1 participant

@JackMorganNZ
Member

Description

The following interactives share the same images:

  • box-rotation
  • box translation
  • high-score-boxes

These should all share the same assets in the base-files folder to avoid repetition, which requires some file shifting and changes to URLs in these interactives. Created from the work required in #391.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the issue.

  • I have linked any relevant existing issues/suggestions in the description above (include #??? in your description to reference an issue, where ??? is the issue number)
  • I have applied relevant labels
@JackMorganNZ JackMorganNZ self-assigned this Oct 12, 2016
@JackMorganNZ
Member

Should also note the searching-algorithms and sorting-algorithms interactives also use these box images but are created in a way which doesn't allow them to share assets.

@JackMorganNZ JackMorganNZ referenced this issue Oct 12, 2016
@JackMorganNZ JackMorganNZ Tidy up high-score-boxes interactive (fixes #391)
The following changes have been made to the
interactive:
- Stop boxes from having sides touching.
- Use box images in the base-files folder,
  rather than make another copy. Also add new
  images to this folder.
- Keep 'Submit' and 'Restart' buttons
  consistent in their formatting.
- Store all JS variables within an object for
  the interactive.
- Use more effiecent jQuery selections.
- Use more precise CSS selectors.
- Tidy HTML and CSS files (whitespace and
  comments).
655ef2c
@JackMorganNZ
Member

Fixed in 7280af2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment