Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCP health checks. #1105

Merged
merged 3 commits into from Jul 23, 2019
Merged

Update GCP health checks. #1105

merged 3 commits into from Jul 23, 2019

Conversation

@courtneycb
Copy link
Contributor

@courtneycb courtneycb commented Jul 23, 2019

We currently use legacy health checks which are now deprecated. This PR upgrades the health checks to 'updated health checks'. Note that the default for timeout_sec is 4 so it no longer needs to be specified.

Useful links:
https://cloud.google.com/appengine/docs/flexible/python/reference/app-yaml#updated_health_checks

https://cloud.google.com/appengine/docs/flexible/python/reference/app-yaml#migrating_to_updated_health_checks

Resolves #1095

@courtneycb courtneycb requested a review from JackMorganNZ Jul 23, 2019
@courtneycb courtneycb self-assigned this Jul 23, 2019
@courtneycb courtneycb merged commit a59f738 into develop Jul 23, 2019
5 checks passed
Loading
@courtneycb courtneycb deleted the issue/1095 branch Jul 23, 2019
@courtneycb courtneycb mentioned this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants