Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCP health checks. #1105

Merged
merged 3 commits into from Jul 23, 2019

Conversation

@courtneycb
Copy link
Contributor

commented Jul 23, 2019

We currently use legacy health checks which are now deprecated. This PR upgrades the health checks to 'updated health checks'. Note that the default for timeout_sec is 4 so it no longer needs to be specified.

Useful links:
https://cloud.google.com/appengine/docs/flexible/python/reference/app-yaml#updated_health_checks

https://cloud.google.com/appengine/docs/flexible/python/reference/app-yaml#migrating_to_updated_health_checks

Resolves #1095

@courtneycb courtneycb requested a review from JackMorganNZ Jul 23, 2019

@courtneycb courtneycb self-assigned this Jul 23, 2019

courtneycb added some commits Jul 23, 2019

@courtneycb courtneycb merged commit a59f738 into develop Jul 23, 2019

5 checks passed

codecov/patch Coverage not affected when comparing b75f21e...b67cfb3
Details
codecov/project 96.07% remains the same compared to b75f21e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@courtneycb courtneycb deleted the issue/1095 branch Jul 23, 2019

@courtneycb courtneycb referenced this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.